Improved the query parsing for table access statistics #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onukristo
changed the title
| The library is pretty good, but some services have few queries, it can not parse. Also, sometimes the parsing can take so long, | ||
| that it will create latency spikes or cpu burns. | ||
|
|
||
| In those case, you can override/control the parsing via `TasQueryParsingInterceptor` and `TasParsedQueryRegistry`. |
There was a problem hiding this comment.
Maybe provide an example here as well how to do it?
tw-peeterkarolin
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changed
Implemented a timeout and interruption for TAS SQL parsing.
Complex queries in one of our services created long duration heavy CPU burn.
Query parsing will use
JSQLParsercomplex parsing immediately.Before, our implementation was using simple parsing. And
JSQLParserimplementation tried by defaultsimplefirstand then
complex, ifsimplefailed.Performance tests showed
simpleparsing for simple queries, is not noticeably faster for simple queries.Created a mechanism for a service to provide parsed query information itself and thus skip the query parsing.
It can be used for complex queries where parsing is slow or for queries which jsqlparser can not handle.
The mechanism can be used via
TableAccessStatisticsParsedQueryRegistryinterface.Added more flexibility around query parsing via
TasQueryParsingListenerandTasQueryParsingInterceptor.Supporting parsing queries with
on conflict (...)clause with multiple parameters.We can remove our own solution, when next
JSQLParserversion would support it.Checklist