Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing more Wise teams to create PRs. #42

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Allowing more Wise teams to create PRs. #42

merged 1 commit into from
Feb 14, 2024

Conversation

onukristo
Copy link
Contributor

@onukristo onukristo commented Feb 14, 2024 •
edited
Loading

Context

Currently only application-engineering team in Wise can create PRs, but all the engineers should.

Allowing more Wise teams to create PRs.

Checklist

@onukristo onukristo added the change:standard Not an emergency or impactful change label Feb 14, 2024
@onukristo onukristo requested a review from a team as a code owner February 14, 2024 11:29
@onukristo
Copy link
Contributor Author

/wise-bot emergency-merge sbom-s are not required for public libs

@wise-github-bot-app wise-github-bot-app bot added change:emergency Change made as part of a declared incident and removed change:standard Not an emergency or impactful change labels Feb 14, 2024
@wise-github-bot-app
Copy link

🟢

Emergency merge requested by onukristo.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 14 days to avoid an SLA breach.
Requester onukristo
Reason sbom-s are not required for public libs
Merge Method squash

@wise-github-bot-app
Copy link

🔴

Sorry, I couldn't merge the PR, check the logs for more info... 😢

HttpError: Not Found

@onukristo
Copy link
Contributor Author

/wise-bot run-action sync-codeowners

@wise-github-bot-app
Copy link

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Synced Comment
application-engineering 🟢 Team was already up to date

You have more info in the docs

@wise-github-bot-app
Copy link

🟢

sync-codeowners action completed with successful result.

@onukristo
Copy link
Contributor Author

/wise-bot emergency-merge sbom-s are not required for public libs

@wise-github-bot-app
Copy link

🟢

Emergency merge requested by onukristo.

This event has been added to the security log. The merge could take few seconds...

Remember that, once it is merged, a maintainer should review the code and approve it retrospectively by commenting /wise-bot approve within 14 days to avoid an SLA breach.
Requester onukristo
Reason sbom-s are not required for public libs
Merge Method squash

@tw-census tw-census merged commit 3f8386b into master Feb 14, 2024
18 checks passed
@wise-github-bot-app
Copy link

Your tw-rules.yaml file has changed. Syncing your branch protection settings:

Branch pattern Applied Comment
master 🟢 Branch succesfully protected.

You have more info in the docs.

@wise-github-bot-app
Copy link

Your CODEOWNERS or the tw-rules.yaml file has changed. Syncing your GitHub teams with your CODEOWNERS file and extraWriters in tw-rules:

Collaborator Name Synced Comment
product-engineering 🟢 Team added with role push
application-engineering 🟢 Team was already up to date
platform 🟢 Team was already up to date

You have more info in the docs

@xSeagullx xSeagullx deleted the sync_codeowners branch February 14, 2024 15:33
@xSeagullx
Copy link
Contributor

/wise-bot approve

@wise-github-bot-app
Copy link

Approved by xSeagullx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xSeagullx xSeagullx xSeagullx approved these changes

Assignees
No one assigned
Labels
change:approved change:emergency Change made as part of a declared incident
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onukristo @xSeagullx @tw-census