Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move number of split quantiles from hardwired to node class member #54

Merged
merged 1 commit into from
May 14, 2024
Merged

Move number of split quantiles from hardwired to node class member #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion wise_pizza/solve/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ def __init__(
self.children = None
self.dim_split = dim_split or {}
self.model = None
# For dimension splitting candidates, hardwired for now
self.num_bins = 10

@property
def depth(self):
Expand Down Expand Up @@ -118,7 +120,7 @@ def error_improvement(self):
if np.any(np.isnan(self.df[dim + "_encoded"])): # pragma: no cover
raise ValueError("NaNs in encoded values")
# Get split candidates for brute force search
deciles = np.array([q / 10.0 for q in range(1, 10)])
deciles = np.array([q / self.num_bins for q in range(1, self.num_bins)])

splits = weighted_quantiles(
self.df[dim + "_encoded"], deciles, self.df["weights"]
Expand Down
Loading