Compatibility issues with JSONDecodeError #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`requests` is somewhat inconsistent with how it raises this exception. (psf/requests#5794) Depending on the environment, the following can happen during `response.json`: - Python2 and no `simplejson`, a `ValueError` will be raised - Python2 and `simplejson`, a `simplejson.JSONDecodeError` will be raised - Python3 and no `simplejson`, a `json.JSONDecodeError` will be raised - Python3 and `simplejson`, a `simplejson.JSONDecodeError` will be raised The following wil make sure that catching `transifex.api.jsonapi.compat.JSONDecodeError` in a `try: response.json()` block will always work
Codecov Report
@@ Coverage Diff @@
## devel #64 +/- ##
==========================================
- Coverage 77.62% 77.41% -0.22%
==========================================
Files 46 46
Lines 3710 3719 +9
==========================================
- Hits 2880 2879 -1
- Misses 830 840 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestsis somewhat inconsistent with how it raises this exception.(psf/requests#5794)
Depending on the environment, the following can happen during
response.json():simplejson, aValueErrorwill be raisedsimplejson, asimplejson.JSONDecodeErrorwill be raisedsimplejson, ajson.JSONDecodeErrorwill be raisedsimplejson, asimplejson.JSONDecodeErrorwill be raisedThe following wil make sure that catching
transifex.api.jsonapi.compat.JSONDecodeErrorin atry: response.json()block will always work