This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
build: using external rollup-plugin-smart-asset #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was enabled by default at some point in the node-resolve plugin, which should already have fixed developit#303 and developit#288. It still prints a warning though, which is illogical when we're compiling for a Node target. This silences that warning.
GitHub actions
Set preferBuiltins:true for Node
Co-authored-by: Ward Peeters <ward@coding-tech.com>
See developit#673 It's not possible to actually specify where to place the declarations file. This PR attempts to clarify the docs.
Co-authored-by: Leah <me@hrmny.sh> Co-authored-by: Leah <github.leah@hrmny.sh>
…it#689) unless I am mistaken the default export name for the module is in camelCase not snake
Co-authored-by: Ward Peeters <ward@coding-tech.com>
I think this should fix developit#704.
* Support global extend via amdName
Using a prefixed name like `{ "amdName": "global.foo" }` will trigger Rollup's `output.extend` option. This addresses the use-case from developit#709 without adding another CLI flag.
* Create chilled-paws-confess.md
* Update chilled-paws-confess.md
There is a small typo in test/index.test.js. Should read `really` rather than `realy`.
Co-authored-by: Leah <github.leah@hrmny.sh>
Co-authored-by: Leah <github.leah@hrmny.sh>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found rollup-plugin-smart-asse's keepImport not working when rollup version < 2.0. this will cause all image build by microbundle become:
not
thus webpack's file-loader not working for bundle image.
I made a change of rollup-plugin-smart-asset to keep it work(inspired by this).
And i found microbundle is already try update rollup to 2.0. so this my be a temporary fix for microbundle. so i don't make a pr for rollup-plugin-smart-asse