Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

Fixed npm install + updates #2

Merged
merged 8 commits into from
Jul 17, 2017
Merged

Fixed npm install + updates #2

merged 8 commits into from
Jul 17, 2017

Conversation

Techn1x
Copy link
Contributor

@Techn1x Techn1x commented Jul 16, 2017

This PR should fix the npm install issues mentioned here #1

leaflet and leaflet-polylinedecorator and other dependencies are now pulled in with npm.

I also updated the package versions for most of these dependencies to much later versions.

I have also renamed the package from @transitland/ember-leaflet-polyline-decorator to just ember-leaflet-polyline-decorator to keep it consistent with other ember-leaflet addon names (feel free to override this if you don't want the package name changed - I am not sure how this affects npm publishing)

Once this PR is pulled in I'll make another PR with an updated readme with basic instructions on usage & installation with npm

I haven't really messed with ember addons before this so while I think I did everything correctly, I could have missed something (but it seems to work for me now)

@doublestranded
Copy link
Contributor

Thank you for taking a look at this, @Techn1x and fixing! It looks like that tricky "normalizeEntityName" empty function was missing. Also it's a good move to transition away from bower towards npm like you suggested. The import function is in line with what I've seen from other addons.

I've tested this PR locally and it works for me (using npm link in the addon directory, npm link ember-leaflet-polyline-decorator in a test app directory and ember generate ember-leaflet-polyline-decorator again in the test app directory). One thing about the Leaflet Draw version is that the Transitland Dispatcher currently relies on an older version of Leaflet Draw, and consequently I think this is why the Leaflet version was older as well (it’s been updated recently). It looks like that functionality is disabled currently, however, so that is a separate issue. Not sure about the name, @drewda will have to weigh in on that.

@drewda
Copy link
Member

drewda commented Jul 17, 2017

Thanks for working on this issue, @Techn1x, and thanks for reviewing, @doublestranded!

I'll merge this PR in now and re-publish (under ember-leaflet-polyline-decorator).

If this introduces any new bugs, please do open new issues and/or PRs!

@drewda drewda merged commit 1710a2d into transitland:master Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants