Skip to content
This repository has been archived by the owner on Mar 12, 2022. It is now read-only.

add JOSM link in map matching result #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add JOSM link in map matching result #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 38 additions & 30 deletions app/map-matching/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,16 +157,16 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
// if (attributes.max_upward_grade !== 0 && attributes.max_downward_grade !== 0) {
// // return "weighted grade: " + attributes.weighted_grade + "%";
// if (-attributes.max_downward_grade >= attributes.max_upward_grade){
// return "max downward grade: " + attributes.max_downward_grade + "%";
// return "max downward grade: " + attributes.max_downward_grade + "%";
// } else {
// return "max upward grade: " + attributes.max_upward_grade + "%";
// }
// } else if (attributes.max_upward_grade !== 0) {
// return "max upward grade: " + attributes.max_upward_grade + "%";
// } else if (attributes.max_downward_grade !== 0) {
// return "max downward grade: " + attributes.max_downward_grade + "%";
// return "max downward grade: " + attributes.max_downward_grade + "%";
// }
return "weighted grade: " + attributes.weighted_grade + "%";
return "weighted grade: " + attributes.weighted_grade + "%";
} else {
return "speed limit: " + attributes[selectedAttribute] + " mph";
}
Expand All @@ -175,6 +175,14 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
var maneuvers = this.model.mapMatchRequests.traceRouteRequest.value.trip.legs[0].maneuvers;
return maneuvers;
}),
josmLink: Ember.computed('showTraceRoute', function(){
var edges = this.model.mapMatchRequests.attributesResponse.value.edges;
var josm_url = "http://localhost:8111/load_object?objects="
for (var i = 0; i < edges.length; i++){
josm_url += "w"+edges[i]['way_id'].toString() + ","
}
return josm_url;
}),
segmentAttributes: Ember.computed('selectedSegment', function(){
if (this.get('selectedSegment')){
var attributes = this.get('selectedSegment').attributes;
Expand Down Expand Up @@ -224,14 +232,14 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
// if (selectedAttribute === 'weighted_grade') {
// if (edges[i].max_upward_grade !== 0 && edges[i].max_downward_grade !== 0) {
// if (-edges[i].max_downward_grade >= edges[i].max_upward_grade){
// attribute = edges[i].max_downward_grade;
// attribute = edges[i].max_downward_grade;
// } else {
// attribute = edges[i].max_upward_grade;
// }
// } else if (edges[i].max_upward_grade !== 0) {
// attribute = edges[i].max_upward_grade;
// } else if (edges[i].max_downward_grade !== 0) {
// attribute = edges[i].max_downward_grade;
// attribute = edges[i].max_downward_grade;
// }
// attribute = edges[i][selectedAttribute];
// } else {
Expand Down Expand Up @@ -261,17 +269,17 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
var begin = edges[i].begin_shape_index;
var end = edges[i].end_shape_index;
var pointsSlice = points.slice(begin, end+1);
var attributes = edges[i];
var attributes = edges[i];
var mid = 0;
// var mid = attributeArrayAverage;
// var mid = attributeArrayMedian;
// var mid = attributeArrayMedian;
var min = attributeArrayMin;
var max = attributeArrayMax;

var attr = edges[i][selectedAttribute];
// find color
if (selectedAttribute === 'weighted_grade') {

// Hue is a degree on the color wheel; 0 (or 360) is red, 120 is green, 240 is blue. Numbers in between reflect different shades.
// Saturation is a percentage value; 100% is the full colour.
// Lightness is also a percentage; 0% is dark (black), 100% is light (white), and 50% is the average.
Expand All @@ -282,11 +290,11 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
// yellow: 60
// red: 0 or 360


var lowColor = 120;
var midColor = 60;
var highColor = 0;

if (attr <= mid){
var range = attributeArrayMin;
var colorRange = lowColor - midColor;
Expand Down Expand Up @@ -324,7 +332,7 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
var color = '#a50026 ';
}

// add segment info to edgeCoordinates array, to use to draw polyline layers on map
// add segment info to edgeCoordinates array, to use to draw polyline layers on map
edgeCoordinates.push({
coordinates: pointsSlice,
color: color,
Expand All @@ -334,15 +342,15 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
}
return edgeCoordinates;
}
}),
}),
actions: {
updatebbox(e) {
var newbox = e.target.getBounds();
this.set('bbox', newbox.toBBoxString());
},
setTrace(trace){
this.set('zoomedDiscontinuity', null);
this.set('selectedDiscontinuity', null);
setTrace(trace){
this.set('zoomedDiscontinuity', null);
this.set('selectedDiscontinuity', null);
this.set('trace', null);
this.set('costing', null);
this.set('showErrorMessage', false);
Expand All @@ -352,9 +360,9 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
if (document.getElementById('gpxFileUpload')){
document.getElementById('gpxFileUpload').value = "";
};
this.set('selectedSegment', null);
this.set('selectedSegment', null);
this.set('showTraceAttribute', false);
this.set('showTraceRoute', false);
this.set('showTraceRoute', false);
this.set('selectedAttribute', null);
this.set('trace', trace.name);
if (trace.name === "user_upload"){
Expand All @@ -372,13 +380,13 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
this.set('errorMessage', this.model.mapMatchRequests.attributesResponse.reason.responseJSON.error);
this.set('showErrorMessage', true);
} else if (this.get('showTraceAttribute')){
this.set('selectedDiscontinuity', null);
this.set('selectedDiscontinuity', null);
this.set('showTraceAttribute', false);
this.set('showTraceRoute', false);
this.set('showTraceRoute', false);
this.set('selectedAttribute', null);
this.set('selectedSegment', null);
this.set('selectedSegment', null);
} else {
this.set('selectedDiscontinuity', null);
this.set('selectedDiscontinuity', null);
this.set('selectedAttribute', null);
this.set('showTraceAttribute', true);
}
Expand All @@ -389,24 +397,24 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
this.set('showTraceRouteErrorMessage', true);
this.set('showTraceRoute', true);
} else if (this.get('showTraceRoute')){
this.set('showTraceRoute', false);
this.set('showTraceRoute', false);
} else {
this.set('showTraceRoute', true);
}
},
styleByAttribute(attribute){
if (this.get('selectedAttribute') === attribute){
this.set('selectedAttribute', null);
this.set('selectedSegment', null);
this.set('selectedSegment', null);
} else {
this.set('selectedAttribute', null);
this.set('selectedSegment', null);
this.set('selectedSegment', null);
var attributesForSelection = this.get('attributesForSelection');
for (var i = 0; i < attributesForSelection.length; i++){
if (attributesForSelection[i].attribute === attribute){
this.set('selectedAttribute', attributesForSelection[i].attribute);
}
}
}
}
},
selectSegment(segment){
Expand All @@ -416,7 +424,7 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
this.set('hoverSegment', null);
},
setSegment(segment){
this.set('selectedSegment', segment);
this.set('selectedSegment', segment);
},
setCosting(mode){
this.set('noTraceUploaded', false);
Expand All @@ -436,13 +444,13 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
this.set('noTraceUploaded', true);
this.set('costing', null);
}

} else {
alert('Sorry, this functionality is not fully supported in your browser.');
}
},
closePopup(){
this.set('selectedSegment', null);
this.set('selectedSegment', null);
},
showSelectedDiscontinuity(traceDiscontinuity){
this.set('selectedDiscontinuity', traceDiscontinuity);
Expand All @@ -457,4 +465,4 @@ export default Ember.Controller.extend(mapBboxController, setTextboxClosed, shar
this.set('zoomedDiscontinuity', null);
}
}
});
});
7 changes: 6 additions & 1 deletion app/map-matching/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
</table>
{{/unless}}
{{#if showTraceAttribute}}

<div class="upload-options">
<h5>Style route segments by:&nbsp;<div class="fa fa-question-circle"></div><br>{{#popover-on-element class="tooltip-on-sidebar" event="click"}}Display each matched line segment by either its slope or speed limit.<br><br>
The <a href="https://mapzen.com/documentation/mobility/explorer/map-matching/#view-the-attributes-of-the-matched-route" target="_blank">weighted grade</a> measure provides an idea of the average grade for each segment, calculated from elevation data.<br><br>
Expand Down Expand Up @@ -235,6 +236,10 @@
</table>
</div>
{{/if}}

<a href="{{josmLink}}" target="_blank">Load route in JOSM</a>
<div class="fa fa-question-circle">{{#popover-on-element class="tooltip-on-sidebar" event="click"}}Open JOSM, and click on the link to load the matched ways.{{/popover-on-element}}</div>

{{#unless model.mapMatchRequests.traceRouteRequest.value.trip}}
<div class="alert alert-warning">
<strong>There was an error matching your trace. </strong><div class="fa fa-question-circle"></div>{{#popover-on-element class="tooltip-on-sidebar" event="click"}}Errors commonly occur when a trace has low GPS accuracy (which often occurs in dense, urban areas), or when the path data doesn't exist in OpenStreetMap.{{/popover-on-element}}<br>
Expand Down Expand Up @@ -271,7 +276,7 @@
{{/if}}
{{/each}}
</div>
{{/unless}}
{{/unless}}
{{/if}}
{{/if}}
</form>
Expand Down