Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed depricated code #3273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahidikram0701
Copy link

No description provided.

@friedelwolff
Copy link
Member

Sorry for only getting to this now.

I currently have Translate Toolkit 2.4.0, and the existing code (with extractpoline) still works. Is it just deprecated, or was the removal reversed? Do we still need this?

@unho
Copy link
Member

unho commented Oct 26, 2019

@friedelwolff If this PR is ok and gets merged, then we would be able to merge PR translate/translate#3596 in Translate Toolkit to get rid of this deprecated function.

@unho
Copy link
Member

unho commented Oct 26, 2019

@friedelwolff Also check PR #3272 which kinda does the same thing as this one.

@friedelwolff
Copy link
Member

The two functions are not equivalent:

>>> from translate.storage import pypo
>>> pypo.extractpoline('"abc"')
'abc'
>>> pypo.unescape('"abc"')
'"abc"'

What am I missing?

@unho
Copy link
Member

unho commented Oct 26, 2019

You are right, they are not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants