Skip to content

Commit

Permalink
xhr-upload: do not emit limit warning if an existing rate limit queue…
Browse files Browse the repository at this point in the history
… was passed
  • Loading branch information
goto-bus-stop committed Jan 6, 2020
1 parent 60c0654 commit 3c1a2af
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/@uppy/xhr-upload/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,8 @@ module.exports = class XHRUpload extends Plugin {
return Promise.resolve()
}

if (this.opts.limit === 0) {
// no limit configured by the user, and no RateLimitedQueue passed in by a "parent" plugin (basically just AwsS3) using the top secret `__queue` option
if (this.opts.limit === 0 && !this.opts.__queue) {
this.uppy.log(
'[XHRUpload] When uploading multiple files at once, consider setting the `limit` option (to `10` for example), to limit the number of concurrent uploads, which helps prevent memory and network issues: https://uppy.io/docs/xhr-upload/#limit-0',
'warning'
Expand Down

0 comments on commit 3c1a2af

Please sign in to comment.