Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableLocalFiles: true with Webcam enabled - hides the camera option on iOS while it still shows on desktop chrome #4430

Closed
2 tasks done
jakemcallister opened this issue Apr 26, 2023 · 2 comments
Closed
2 tasks done

disableLocalFiles: true with Webcam enabled - hides the camera option on iOS while it still shows on desktop chrome #4430

jakemcallister opened this issue Apr 26, 2023 · 2 comments
Assignees
@arturi
Labels
Bug

Comments

@jakemcallister
Copy link
Contributor

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

https://codepen.io/jakemcallister-the-reactor/pen/jOemvbV

Steps to reproduce

A basic example with with disableLocalFiles set to true.

<html lang="en">
  <head>
    <title></title>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <link href="https://releases.transloadit.com/uppy/v3.8.0/uppy.min.css" rel="stylesheet" />
  </head>
  <body>
    <noscript>You need JavaScript enabled for this example to work.</noscript>
    <button id="uppyModalOpener">Open Modal</button>

    <script type="module">
      import {
        Uppy,
        Dashboard,
        Webcam,
      } from "https://releases.transloadit.com/uppy/v3.8.0/uppy.min.mjs";

      const uppy = new Uppy({ debug: true, autoProceed: false })
        .use(Dashboard, { trigger: "#uppyModalOpener", disableLocalFiles: true })
        .use(Webcam, { target: Dashboard })
    </script>
  </body>
</html>

Expected behavior

This should:

  1. Disable the drag files onto the modal to upload
  2. Remove the "my device" button
  3. Leave only the camera option

Actual behavior

On mac chrome it works as expected:

Screenshot 2023-04-26 at 17 02 00

However on iOS safari it shows just an empty modal

IMG_1760
@arturi arturi removed the Triage label Jul 6, 2023
@jakemcallister
Copy link
Contributor Author

Has anyone got any ideas on this one?

jakemcallister added a commit to jakemcallister/uppy that referenced this issue Jan 26, 2024
@jakemcallister
Update AddFiles.jsx
a656c79 
Uncouple the native camera and video buttons from the option disableLocalFiles to solve issue transloadit#4430
@jakemcallister jakemcallister mentioned this issue Jan 26, 2024
Merged
arturi pushed a commit that referenced this issue Feb 1, 2024
@jakemcallister
Update AddFiles.jsx (#4894)
93c5e0a 
Uncouple the native camera and video buttons from the option disableLocalFiles to solve issue #4430
@aduh95
Copy link
Contributor

aduh95 commented Feb 19, 2024 •
edited
Loading

The fix was released with Uppy 3.22.0

@aduh95 aduh95 closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arturi arturi

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakemcallister @arturi @aduh95