-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-s3-multipart: Self-signed request does NOT escape path according to RFC 3986 #5005
Closed
2 tasks done
Labels
Comments
I will send PR to fix this and may include info what is a difference between uppy's implementation and AWS SDK's one. |
hiromi2424
added a commit
to hiromi2424/uppy
that referenced
this issue
Mar 18, 2024
I'm not sure RFC 3986 requires escaping those characters, but I suppose that hardly matters if AWS requires it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Initial checklist
Link to runnable example
https://github.com/transloadit/uppy/tree/main/packages/%40uppy/companion
Steps to reproduce
Very simple to say one phrase, this is reproduced by using
AWS-S3-Multipart
withcompanionUrl
andgetTemporarySecurityCredentials :true
options.Runnable example will be produced by @uppy/companion server with making setup s3-multipart, S3 CORS-policy and sts federation permission.
Note that default key implementation makes key including filename so that special chars in name of uploading file causes error.
After above setup, try upload file with special chars in file name. (Example:
!'()*.txt
)Expected behavior
Actual behavior
The text was updated successfully, but these errors were encountered: