Adding COMPANION_SECRET does not pick up the secret value

[gprasad98]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Testing a Companion server in standalone for our application. Running it with the secret as either env variable or through a config json doesn't seem to work. Config below

{
    "server": {
      "host": "companion.xxx.com",
      "protocol": "https"
    },
    "allowLocalUrls": true,
    "filePath": "/home/user/uppy/data",
    "uploadUrls": ["https://xxx.example.com"],
    "streamingUpload": true,
    "secret": "IssaSecretThatMightWork"
}

Also tried COMPANION_SECRET as well as COMPANION_SECRET_FILE which did not help

Expected behavior

Companion uses the provided secret string IssaSecretThatMightWork

Actual behavior

It does not use the provided string instead there is a warning on secret not being set

0|companio | companion: 2024-06-07T13:31:17.362Z [warn] startup.secret auto-generating server secret because none was specified
0|companio | companion: 2024-06-07T13:31:17.397Z [info] jobs.cleanup.start starting clean up job
0|companio | companion: 2024-06-07T13:31:17.431Z [info]  Welcome to Companion! v4.13.3
0|companio | companion: 2024-06-07T13:31:17.432Z [info]  Listening on http://localhost:3020

[mifi]

I suspect that companion detects the secret correctly, but it triggers the warning message due to preAuthSecret not being set. see

uppy/packages/@uppy/companion/src/standalone/index.js

Line 26 in 22d2d2e

if (!companionOptions.preAuthSecret) companionOptions.preAuthSecret = generateSecret()

If you don't use the preauth feature in companion, you should be able to disable the message by setting a dummy value e.g. COMPANION_PREAUTH_SECRET=unused

we should probably improve this log message to include "preauth secret" in this case