Recent commit caused custom providers to break

[vikas-rajvanshy]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

Create a custom provider, when running companion and requesting the custom provider service will throw an exception here:

packages/@uppy/companion/src/server/provider/index.js
module.exports.getProviderMiddleware = (providers, grantConfig) => {
const { secret } = providerOptions[providerName];

Reason is that secret is not set in providerOptions for custom providers (since they have their own object). I believe this is a recent regression from #5249

Expected behavior

Request should not bail for custom providers

Actual behavior

Exception occurs

[Murderlon]

Hi, do you have a minimal reproducible example for us that fails?

[vikas-rajvanshy]

The following custom provider illustrates the issue:

const companionOptions = {
    customProviders: {
		sharefile: {
			config: {
				authorize_url: 'https://secure.sharefile.com/oauth/authorize',
				access_url: 'https://secure.sharefile.com/oauth/token',
				oauth: 2,
				key: 'xxxx',
				secret: 'xxxx',
                                redirect_uri: 'https:<domain>/sharefile/redirect',
			},
			module: ShareFile,
		},
	},    
};

If you make request for this particular provider, it will hit the codepath in middleware that expects it to be in the built in provider set and crash.

[mifi]

#5398