form: exclude own metadata, append result instead of overwriting #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 1st thing LGTM 👍 . We could land it first and publish as a patch, then nobody has to worry about upgrading. |
|
I could also add the second thing as an option, |
|
i could live with that :P |
…ult, with option to append
|
@goto-bus-stop updated, please take a look 🙏 |
packages/@uppy/form/src/index.js
Outdated
| @@ -23,6 +23,7 @@ module.exports = class Form extends Plugin { | |||
| resultName: 'uppyResult', | |||
| getMetaFromForm: true, | |||
| addResultToForm: true, | |||
| replaceResultInFormWithNew: true, | |||
There was a problem hiding this comment.
🚲 🏚️ , but maybe the default option should be multipleResults: false or combineMultipleResults: false? i feel like replaceResultInFormWithNew is very verbose but also doesn't immediately clarify what it's for.
arturi
force-pushed
the
form-exclude-own-meta
branch
from
3d63a2c to
42032aa
Compare
arturi
force-pushed
the
form-exclude-own-meta
branch
from
42032aa to
f68059e
Compare
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
Formappended to a<form>element, when gathering metadata from that form. Addresses ASSEMBLY_SATURATED when re-picking a file for robodog's form integration #1637, where because of this issue we were sending a huge amount of metadata totusd— the wholecompleteobject, instead of metadata intended by the user/dev.valuesent to the server was an object, now it’s an array.