Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: add options to show remove button after complete #2284

Merged
merged 3 commits into from
May 25, 2020
Merged

Dashboard: add options to show remove button after complete #2284

merged 3 commits into from
May 25, 2020

Conversation

arturi
Copy link
Contributor

@arturi arturi commented May 21, 2020

Closes #2131 and so many others:

yamifr07 commented on Mar 27
If the library just display a delete button developers can implement their own delete logic. I really like this plugin but I must be able to edit uploaded data

Also fixes an issue which broke “copy link” functionality after #2161

@arturi arturi requested a review from goto-bus-stop May 21, 2020 21:34
goto-bus-stop
goto-bus-stop approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goto-bus-stop goto-bus-stop merged commit 99db9f2 into master May 25, 2020
@goto-bus-stop goto-bus-stop deleted the dashboard-showRemoveButtonAfterComplete branch May 25, 2020 12:33
@iicdii iicdii mentioned this pull request Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove uploaded documents
2 participants
@arturi @goto-bus-stop