companion: add calculated content-length for formdata and body cases #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I'll review this week |
mejiaej
force-pushed
the
master
branch
2 times, most recently
from
933710e to
4cef783
Compare
| statusText: response.statusMessage, | ||
| headers | ||
| } | ||
| _handleUploadMultipart (error, response, body, bytesUploaded) { |
There was a problem hiding this comment.
should we rename this to _onMultipartComplete or something similar?
There was a problem hiding this comment.
Totally agree, I think it is more descriptive.
Co-authored-by: Ifedapo .A. Olarewaju <ifedapoolarewaju@gmail.com>
|
thank you for the work here! 🎉 |
|
@ifedapoolarewaju Thanks for the review and feedback. |
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
…loadit#2466) * companion: add calculated content-length for formdata and body cases * companion: append fieldname and emit error in form data Co-authored-by: Ifedapo .A. Olarewaju <ifedapoolarewaju@gmail.com> * companion: change _handleUploadMultipart to _onMultipartComplete * companion: use async fs.stat Co-authored-by: Enrique Jhonatan Mejia Venegas <enrique.mejia@LIM-WS1807.local> Co-authored-by: Ifedapo .A. Olarewaju <ifedapoolarewaju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as described in this PR
content-lengthis an expected header when uploading to s3. In this PR I'm adding context-length calculation for the formData scenario. Had to factor out the http request sinceform.getLengthfrom form-data expects a callback.