Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragDrop: redesign, add note, width/height options, arrow icon #374

Merged
merged 8 commits into from
Oct 3, 2017

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Oct 3, 2017

From Alex’s mockup:

pasted image at 2017_09_29 06_03 pm

The DragDrop plugin looks like this now:

screen shot 2017-10-03 at 2 10 14 pm

  • added width, height (both 100% by default to fill the entire container space) and note options
  • added arrow icon; white background
  • refactored CSS and class names
  • removed selectedFiles count for now

@arturi
Copy link
Contributor Author

arturi commented Oct 3, 2017

//cc @kvz @nqst

@kvz
Copy link
Member

kvz commented Oct 3, 2017

Very Nice!!!

@arturi arturi changed the title DragDrop: redesign, add note, width/height options, arrow icon DragDrop: redesign, add note, width/height options, arrow icon Oct 3, 2017
@arturi arturi merged commit 4a89877 into master Oct 3, 2017
@arturi arturi deleted the improvement/dragdrop branch October 3, 2017 21:06
@nqst
Copy link
Contributor

nqst commented Oct 4, 2017

Awesome!!

@Chikel
Copy link

Chikel commented Feb 6, 2018

will it be possible to customize the DragDrop arrow icon?

@arturi
Copy link
Contributor Author

arturi commented Feb 7, 2018

It is possible to hide the one we use with CSS, I think, and then add your own with pseudo classes in CSS. Would you say an option to use custom icon url or SVG string would be useful? What icon would you like to show there?

@Chikel
Copy link

Chikel commented Feb 9, 2018

We have a custom icon we would like to use. I think it would have been useful if the plugins were more flexible in terms of styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants