@uppy/xhr-upload: add 'upload-stalled' event
#4247
Conversation
aduh95
changed the title
'upload-stalled' event'upload-stalled' event
Co-authored-by: Merlijn Vos <merlijn@soverin.net>
|
Note that any changes made to the docs must also happen in https://github.com/transloadit/uppy.io |
Co-authored-by: Merlijn Vos <merlijn@soverin.net>
website/src/docs/core.md
Outdated
| uppy.off('upload-progress', uploadProgressHandler) | ||
| } | ||
| } | ||
| uppy.on('upload-progress', uploadProgressHandler) |
There was a problem hiding this comment.
Why do we need to set this handler again?
There was a problem hiding this comment.
It's to illustrate how to detect when the upload is no longer stalled.
There was a problem hiding this comment.
Perhaps we can add a comment about it. Or actually show an example that informs the user, as that's what we talk about above
"Use this event to display a message on the UI to tell the user they might want to retry the upload."
Now it's a bit confusing to me how retrying works together with this.
There was a problem hiding this comment.
I've updated the variable name so it's clearer, PTAL
| let uploadStalledWarningRecentlyEmitted | ||
| this.on('upload-stalled', (error, files) => { | ||
| const { message } = error | ||
| const details = files.map(file => file.meta.name).join(', ') |
There was a problem hiding this comment.
Think is going to look bad as soon as you have more than 10 files. I would say this is a general problem in informer. It's probably best if we could inline errors per file always and use infomer only for generic updates. Any chance we can reuse the meta data validation?
There was a problem hiding this comment.
Note that the details is not shown by default, it's only visible if the user click on the ? on the informer bubble.
|
Tested with local XHR server and cutting off internet in the middle of the upload, both bundle and non-bundle work. Bundle lists all the files in the (?), non-bundle only shows one error with one file in the (?).
|
|
Still wasn't able to upload anything slow to Heroku:
|
aduh95
added
the
safe to test
github-actions
bot
removed
pending end-to-end tests
safe to test
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.0.4 | @uppy/screen-capture | 3.0.2 | | @uppy/companion | 4.3.0 | @uppy/transloadit | 3.1.1 | | @uppy/core | 3.0.6 | @uppy/xhr-upload | 3.1.0 | | @uppy/dashboard | 3.2.2 | uppy | 3.5.0 | | @uppy/locales | 3.0.6 | | | - @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / #4316) - meta: Remove Robodog advice, since it is deprecated (Artur Paikin) - @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / #4306) - @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / #4292) - @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / #4302) - @uppy/locales: Update de_DE.js (Jörn Velten / #4297) - meta: use load balancer for companion in e2e tests (Mikael Finstad / #4228) - @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / #4286) - @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / #4247) - @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / #4282)
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.0.4 | @uppy/screen-capture | 3.0.2 | | @uppy/companion | 4.3.0 | @uppy/transloadit | 3.1.1 | | @uppy/core | 3.0.6 | @uppy/xhr-upload | 3.1.0 | | @uppy/dashboard | 3.2.2 | uppy | 3.5.0 | | @uppy/locales | 3.0.6 | | | - @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / transloadit#4316) - meta: Remove Robodog advice, since it is deprecated (Artur Paikin) - @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / transloadit#4306) - @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / transloadit#4292) - @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / transloadit#4302) - @uppy/locales: Update de_DE.js (Jörn Velten / transloadit#4297) - meta: use load balancer for companion in e2e tests (Mikael Finstad / transloadit#4228) - @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / transloadit#4286) - @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / transloadit#4247) - @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / transloadit#4282)
Instead of cancelling the upload, let's give the user control over what to do when a stalling is detected.
The stall detection was added in #378, but using a hard-coded time limit is probably not a good idea.