Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/angular: fix TS build errors #4829

Closed
wants to merge 1 commit into from
Closed

@uppy/angular: fix TS build errors #4829

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 15, 2023

Now that @uppy/core is typed, we have a few types to update in @uppy/angular (which is consuming it). Not sure if setting Meta and Body as mandatory is the best DX, but at least that makes the CI green.

@aduh95 aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Dec 15, 2023
@github-actions github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels Dec 15, 2023
Murderlon
Murderlon approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately passing meta and body explicitly is a must. We should test soon however that we only need to pass it once into core, and that inside use() we can pass the types on to the plugin, rather than passing it on every plugin explicitly

@aduh95 aduh95 marked this pull request as draft January 2, 2024 14:28
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 2, 2024

There are going to be more stuff to fix as we are refactoring more of @uppy/angular deps to TS, converting to draft for now, let's revisit once all the deps have been refactored.

@gongAll gongAll mentioned this pull request Feb 1, 2024
Closed
2 tasks
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 20, 2024

Closing in favor of #5008

@aduh95 aduh95 closed this Mar 20, 2024
@aduh95 aduh95 deleted the fix-angular-build branch March 20, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduh95 @Murderlon