@uppy/core: use variadic arguments for uppy.use

[aduh95]

We want TS to report an error when opts is defined as mandatory in the plugin constructor and missing from the .use call.

[github-actions]

Diff output files

diff --git a/packages/@uppy/core/lib/Uppy.js b/packages/@uppy/core/lib/Uppy.js
index 49d6503..708c152 100644
--- a/packages/@uppy/core/lib/Uppy.js
+++ b/packages/@uppy/core/lib/Uppy.js
@@ -790,13 +790,16 @@ export class Uppy {
   getID() {
     return this.opts.id;
   }
-  use(Plugin, opts) {
+  use(Plugin) {
     if (typeof Plugin !== "function") {
       const msg = `Expected a plugin class, but got ${Plugin === null ? "null" : typeof Plugin}.`
         + " Please verify that the plugin was imported and spelled correctly.";
       throw new TypeError(msg);
     }
-    const plugin = new Plugin(this, opts);
+    for (var _len2 = arguments.length, args = new Array(_len2 > 1 ? _len2 - 1 : 0), _key2 = 1; _key2 < _len2; _key2++) {
+      args[_key2 - 1] = arguments[_key2];
+    }
+    const plugin = new Plugin(this, ...args);
     const pluginId = plugin.id;
     if (!pluginId) {
       throw new Error("Your plugin must have an id");

[Murderlon]

I don't understand the benefit of this 🤔

[aduh95]

I don't understand the benefit of this 🤔

See the types error, it already shows issues with our types (where the opts argument is specified as mandatory instead of, well, optional)

[Murderlon]

Do we want to merge this into main instead?

[aduh95]

It seems safer to keep it for 4.0 only. It's not very urgent anyway, it's just a nice-to-have.