Use title consistently from locales

[Murderlon]

Closes #5018

[github-actions]

Diff output files

diff --git a/packages/@uppy/dropbox/lib/Dropbox.js b/packages/@uppy/dropbox/lib/Dropbox.js
index a4afcd2..0dc6fc3 100644
--- a/packages/@uppy/dropbox/lib/Dropbox.js
+++ b/packages/@uppy/dropbox/lib/Dropbox.js
@@ -42,7 +42,7 @@ export default class Dropbox extends UIPlugin {
     });
     this.defaultLocale = locale;
     this.i18nInit();
-    this.title = this.opts.title || this.i18n("pluginNameDropbox");
+    this.title = this.i18n("pluginNameDropbox");
     this.onFirstRender = this.onFirstRender.bind(this);
     this.render = this.render.bind(this);
   }
diff --git a/packages/@uppy/screen-capture/lib/ScreenCapture.js b/packages/@uppy/screen-capture/lib/ScreenCapture.js
index f2e4146..a491154 100644
--- a/packages/@uppy/screen-capture/lib/ScreenCapture.js
+++ b/packages/@uppy/screen-capture/lib/ScreenCapture.js
@@ -52,11 +52,11 @@ export default class ScreenCapture extends UIPlugin {
     this.mediaDevices = getMediaDevices();
     this.protocol = location.protocol === "https:" ? "https" : "http";
     this.id = this.opts.id || "ScreenCapture";
-    this.title = this.opts.title || "Screencast";
     this.type = "acquirer";
     this.icon = ScreenRecIcon;
     this.defaultLocale = locale;
     this.i18nInit();
+    this.title = this.i18n("pluginNameScreenCapture");
     this.install = this.install.bind(this);
     this.setPluginState = this.setPluginState.bind(this);
     this.render = this.render.bind(this);
diff --git a/packages/@uppy/screen-capture/lib/locale.js b/packages/@uppy/screen-capture/lib/locale.js
index 67781c6..3d42e1e 100644
--- a/packages/@uppy/screen-capture/lib/locale.js
+++ b/packages/@uppy/screen-capture/lib/locale.js
@@ -1,5 +1,6 @@
 export default {
   strings: {
+    pluginNameScreenCapture: "Screencast",
     startCapturing: "Begin screen capturing",
     stopCapturing: "Stop screen capturing",
     submitRecordedFile: "Submit recorded file",
diff --git a/packages/@uppy/unsplash/lib/Unsplash.js b/packages/@uppy/unsplash/lib/Unsplash.js
index 9a4f674..80bad02 100644
--- a/packages/@uppy/unsplash/lib/Unsplash.js
+++ b/packages/@uppy/unsplash/lib/Unsplash.js
@@ -2,6 +2,7 @@ import { getAllowedHosts, SearchProvider, tokenStorage } from "@uppy/companion-c
 import { UIPlugin } from "@uppy/core";
 import { SearchProviderViews } from "@uppy/provider-views";
 import { h } from "preact";
+import locale from "./locale.js";
 const packageJson = {
   "version": "4.0.0-beta.5",
 };
@@ -12,7 +13,9 @@ export default class Unsplash extends UIPlugin {
     this.files = [];
     this.storage = this.opts.storage || tokenStorage;
     this.id = this.opts.id || "Unsplash";
-    this.title = this.opts.title || "Unsplash";
+    this.defaultLocale = locale;
+    this.i18nInit();
+    this.title = this.i18n("pluginNameUnsplash");
     this.icon = () =>
       h(
         "svg",
diff --git a/packages/@uppy/url/lib/Url.js b/packages/@uppy/url/lib/Url.js
index d08f9ff..6cf994c 100644
--- a/packages/@uppy/url/lib/Url.js
+++ b/packages/@uppy/url/lib/Url.js
@@ -129,11 +129,11 @@ export default class Url extends UIPlugin {
       });
     };
     this.id = this.opts.id || "Url";
-    this.title = this.opts.title || "Link";
     this.type = "acquirer";
     this.icon = () => h(UrlIcon, null);
     this.defaultLocale = locale;
     this.i18nInit();
+    this.title = this.i18n("pluginNameUrl");
     this.hostname = this.opts.companionUrl;
     if (!this.hostname) {
       throw new Error("Companion hostname is required, please consult https://uppy.io/docs/companion");
diff --git a/packages/@uppy/url/lib/locale.js b/packages/@uppy/url/lib/locale.js
index dcad1af..325367f 100644
--- a/packages/@uppy/url/lib/locale.js
+++ b/packages/@uppy/url/lib/locale.js
@@ -1,5 +1,6 @@
 export default {
   strings: {
+    pluginNameUrl: "Link",
     import: "Import",
     enterUrlToImport: "Enter URL to import a file",
     failedToFetch: "Companion failed to fetch this URL, please make sure it’s correct",

[aduh95]

Shouldn't we remove title from the list of options in the types as well?

[aduh95]

We still have

uppy/packages/@uppy/screen-capture/src/ScreenCapture.tsx

Line 26 in 5e87d31

title?: string