Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add react dev dashboard #5338

Closed
wants to merge 1 commit into from
Closed

meta: add react dev dashboard #5338

wants to merge 1 commit into from

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Jul 15, 2024

This reverts commit ff416f9.

(cherry picked from commit 44ead928f0c5c82563d29013a46e59c9397c9f8b)

#5260

This reverts commit ff416f9.

(cherry picked from commit 44ead928f0c5c82563d29013a46e59c9397c9f8b)
Copy link
Contributor

Diff output files
No diff

@aduh95 aduh95 changed the title Revert "revert changes in private/" meta: add react dev dashboard Jul 15, 2024
@Murderlon
Copy link
Member

Tested locally and I get add the hooks as our setup breaks. This has to do with how we setup vite for the rest of our dev setup. Since we already have examples/react-example, which we can perfectly use for local React development as we just reference the workspace packages, I think we can close this.

@Murderlon Murderlon closed this Aug 28, 2024
@mifi
Copy link
Contributor Author

mifi commented Aug 29, 2024

I get add the hooks as our setup breaks

what do you mean by that?

We had so many problems with broken uppy in react in the past and misunderstandings around how it works, so I think it makes a lot of sense to have a react dev dashboard with hot reload where we can easily test our code in react too before committing.

examples/react-example, which we can perfectly use for local React development

I strongly disagree:

  • I usually test with yarn dev:with-companion, not using projects from the examples folder. Having react also in yarn dev will help reduce the chance of introducing react bugs. Without this PR I'd have to run two yarn dev command in different folders to test everything.
  • When using cd examples/react-example && yarn dev:
    • companion is not active so the companion part of uppy cannot be tested.
    • there is no hot reload, so you have to stop/start the yarn dev command as well as rebuild uppy every time you make changes
    • you don't get the convenience of just changing .env variables in order to enable different options/plugins
    • if you start both commands, depending on which of the two commands you started first (yarn dev:with-companion or cd examples/react-example && yarn dev), you'll get one running on port 5173, and the other on 5174. if you start the other way around, you'll get the opposite result. this is first of all confusing, and it causes local storage & cookies to be lost, and it completely break because of CORS when testing companion (origin 'http://localhost:5173' has been blocked by CORS policy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants