Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use <h1> in Uppy markup #5355

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Don't use <h1> in Uppy markup #5355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c5bad
everywhere - don't use `<h1>` in Uppy markup
lakesare Jul 17, 2024
ceae7c0
`/dev/Dashboard.js` - add defence against using heading tags
lakesare Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@uppy/audio/src/PermissionsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ export default (props: PermissionsScreenProps) => {
return (
<div className="uppy-Audio-permissons">
<div className="uppy-Audio-permissonsIcon">{icon()}</div>
<h1 className="uppy-Audio-title">
<div className="uppy-Audio-title">
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
{hasAudio ? i18n('allowAudioAccessTitle') : i18n('noAudioTitle')}
</h1>
</div>
<p>
{hasAudio ?
i18n('allowAudioAccessDescription')
Expand Down
4 changes: 2 additions & 2 deletions packages/@uppy/webcam/src/PermissionsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export default function PermissionsScreen({
return (
<div className="uppy-Webcam-permissons">
<div className="uppy-Webcam-permissonsIcon">{icon()}</div>
<h1 className="uppy-Webcam-title">
<div className="uppy-Webcam-title">
{hasCamera ? i18n('allowAccessTitle') : i18n('noCameraTitle')}
</h1>
</div>
<p>
{hasCamera ?
i18n('allowAccessDescription')
Expand Down
11 changes: 9 additions & 2 deletions private/dev/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,14 @@
margin: auto;
}

/* css to make sure that Dashboard's css overrides page css */
button,
input {
color: green;
font-size: 30px;
text-align: right;
border: 2px solid purple;
}

/* css to make sure that Dashboard's css overrides page css */
ul {
margin: 60px;
}
Expand All @@ -40,6 +39,14 @@
a {
color: purple;
}
h1,
h2,
h3,
h4,
h5,
h6 {
color: green;
}
</style>
</head>

Expand Down