Fix C2SP compliance and simplify #325
Merged
+314
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
fix_witness_c2sp_spec_in_witness_api
branch
from
a5214d1 to
237fcdd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
===========================================
- Coverage 51.05% 23.10% -27.95%
===========================================
Files 11 25 +14
Lines 903 1878 +975
===========================================
- Hits 461 434 -27
- Misses 374 1366 +992
- Partials 68 78 +10 ☔ View full report in Codecov by Sentry. |
AlCutter
changed the title
AlCutter
force-pushed
the
fix_witness_c2sp_spec_in_witness_api
branch
from
52ea9cd to
b84d22a
Compare
mhutchinson
approved these changes
Jan 30, 2025
| w.Header().Add("Content-Type", "text/x.tlog.size") | ||
| } | ||
| w.WriteHeader(sc) | ||
| if len(body) > 0 { |
There was a problem hiding this comment.
Minor consistency nit: here you use len(x) > 0 but above you do x != "". Can we pick one style of empty checking?
There was a problem hiding this comment.
Sadly not: body is a []byte, so we're stuck with len here, but for strings != "" is the more "idiomatic"/concise way.
AlCutter
force-pushed
the
fix_witness_c2sp_spec_in_witness_api
branch
from
568ef3c to
5b1b9d4
Compare
mhutchinson
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a deeper fix to the C2SP
tlog-witnesscompliance issues, which changes the internal witness API to better match.Also removes the call to
Updateexposed via the local HTTP server.TODO(al): Either in here, or in a follow-up, make
Updatejust return the sig rather than the whole CP.