Created onboarding page without logic implemented + removed email and password fields of sign in and sign up pages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… feature/onboarding-page
…oved sign and sign up using email and password, and finished validations in the last component
Gutts-n
changed the title
5 tasks
Gutts-n
changed the title
… feature/onboarding-page
luccasmmg
requested changes
Aug 30, 2024
luccasmmg
requested changes
Aug 30, 2024
There was a problem hiding this comment.
On a general note, wheneaver you can you should start to use react-hook-form and zod
https://ui.shadcn.com/docs/components/form
Its ok if you dont make all components work with that (the multiple emails) or the combobox, but as a general guideline you should already be putting validation logic in a zod schema otherwise thats going to be work thats going to fall to whoeaver implements the actual form in the end
Gutts-n
changed the title
… feature/onboarding-page
luccasmmg
approved these changes
Aug 30, 2024
… feature/onboarding-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue: #19
Related issues: #5, #6
Created onboarding steps without integration with the backend and removed email and password fields of sign up and sign in.
Code review to @demenech or @luccasmmg