Dataset page #25
Dataset page #25
Conversation
* add partners images and video thumbnails * increase header z index * Add Heading Component * add default rounded rule to button component * Add Hero, Datasets Sections - wip: contribute, testimonials, faq, newsletter * add contribute section * install accordion ui * fix footer bg * Add Faqs Section * remove unused variables * add ui-avatars as image domain * add tabs ui component * hide contribute section image on sm screens * add testimonials section * remove ui-avatar api * add newsleter * add toaster * add badge component * add border right to latest datasets
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The icon stuff im not really planning on fixing right now, i wanted to see if they had an icon pack first, cause loading the icons as svg images is not really nice since it requires extra http requests just to get the icon (Instead of having it in the mockup from the start) You can check that by using your browser to simulate a slow 3g and opening up the "Downloads" tab, the icons there were taken directly from the mockup, you will see them taking a while to load The
|
|
The problem with taking the icons as images from the figma Screencast.from.2024-08-30.17-52-27.webm |
There was a problem hiding this comment.
Different icons here:
The buttons sizes differ from the mockup and the right button is misaligned with the one on the left.
No responsivity in the tabs sections generating horizontal scroll:
Copy to clipboard button bg color, icon, and spacing differ from the mockup:
The resources icons are a little flat compared with the mockup and the downloads icons differ from the mockup as well:
|
LGTM. |
No description provided.