Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar UI Component #34

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Searchbar UI Component #34

merged 9 commits into from
Sep 6, 2024

Conversation

willy1989cv
Copy link
Contributor

Issue: #29

Implement Search component and its different states.

  • Initial state when user is yet to type a word:
    • Facets (in, before, after...) filtering
    • Recently searched
  • When user starts typing:
    • Datasets results
    • Indicators results
    • Others

@willy1989cv willy1989cv requested a review from Gutts-n September 3, 2024 01:24
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tdc-data-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 0:35am

@willy1989cv willy1989cv changed the title Searchbar UI Component [WIP] Searchbar UI Component Sep 3, 2024
@luccasmmg
Copy link
Contributor

luccasmmg commented Sep 3, 2024

1 - If you type in:something then hit space, it should have an in:something in the combobox, you need to keep this state,
2 - besides i cant select anything
3 - If you click on in: it should create an input in the combobox with in: already there

Another possibility is that everytime you type something and click on the in section, it automatically adds an item with in:{what you typed}

Essentially that combobox needs to be behind the scenes a form that hold

{
in: z.string()
after: z.string()
before: z.string()
sector: z.string()
indicator: <- Not sure on this one
}

Besides it should show some datasets as well

Check this
image

Screencast.from.2024-09-03.10-15-42.webm

@willy1989cv willy1989cv changed the title [WIP] Searchbar UI Component Searchbar UI Component Sep 6, 2024
Copy link
Contributor

@Gutts-n Gutts-n Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should present the user's selected filter. I clicked in in: and the input didn't present the in as the mockup
image
image

The text does not change the color of the dataset title as the mockup:
image
image

Not required but good to improve the UX

It would be good to have a backspace listener to remove the tag when the user types backspace and there isn't text in the input.
image

@Gutts-n Gutts-n merged commit d58eee6 into main Sep 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants