Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CKAN client #35

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Add a CKAN client #35

merged 12 commits into from
Nov 29, 2024

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Nov 28, 2024 •
edited
Loading

Closes #3

Housekeeping:

  • Switch to faster uv to install Python packages.
  • Bump versions of mypy and ruff used for code quality checking.
  • Add hashes for ATO data files.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added the enh New feature or request label Nov 28, 2024
@khaeru khaeru self-assigned this Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (5a3de4a) to head (8958bfa).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   96.26%   96.50%   +0.24%     
==========================================
  Files          60       64       +4     
  Lines        2545     2720     +175     
==========================================
+ Hits         2450     2625     +175     
  Misses         95       95
Files with missing lines Coverage Δ
transport_data/adb/__init__.py 98.33% <100.00%> (ø)
transport_data/oica/__init__.py 97.38% <100.00%> (ø)
transport_data/org/ckan.py 100.00% <100.00%> (ø)
transport_data/org/metadata/spreadsheet.py 100.00% <100.00%> (ø)
transport_data/tests/org/test_ckan.py 100.00% <100.00%> (ø)
transport_data/tests/util/test_ckan.py 100.00% <100.00%> (ø)
transport_data/util/ckan.py 100.00% <100.00%> (ø)

khaeru added a commit that referenced this pull request Nov 29, 2024
@khaeru
Add #35 to doc/whatsnew
f572ef0
@khaeru
Bump mypy, ruff versions; update type hints
d15406f 
- mypy v1.11.2 → v1.13.0
- ruff v0.6.9 → v0.8.1
- Update to satisfy mypy with:
  - pandas-stubs 2.2.3.241126
  - types-openpyxl 3.1.5.20241126
@khaeru
Store hashes for ADB ATO files
c9bbe75 
This forces to re-download the files on GitHub Actions runners if a
previous, partial download with incorrect hash is present.
@khaeru
Update hashes for ATO files
8958bfa 
- Previous hashes from files whose .xlsx metadata shows they were
  updated 2024-05-20.
- Current hashes from files updated 2024-11-14.
@khaeru khaeru merged commit a716994 into main Nov 29, 2024
20 checks passed
This was referenced Dec 13, 2024
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@khaeru khaeru

Labels
enh New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a CKAN client
1 participant
@khaeru