Horizontally fit or center images #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:O no ones ever fixed a bug on one of my repos before... |
|
Your fix was included in v1.1.0. https://github.com/trashhalo/imgcat/releases/tag/v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code only checks that the image fits the screen vertically. If the image aspect ratio is wider than of the terminal window; then line wrapping will occur and the image will be distorted.
This patch also keeps track of terminal width; and attempts to fit the image in both directions using the
resize.Thumbnailfunction instead ofresize.Resize.Left: Original, Right: Fitted
I also horizontally center the image if the width is wider:
