fix reading from socket error queue #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A select info is generated whenever there is something to read from the socket, in C terms `(POLLIN | POLLERR)`. There is no distinction whether that is normal read or errqueue read (POLLERR). This adds a heuristic to read the errqueue should we get no data from a normal socket read.
vkatsuba
reviewed
Dec 1, 2020
vkatsuba
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A select info is generated whenever there is something to read from
the socket, in C terms
(POLLIN | POLLERR). There is no distinctionwhether that is normal read or errqueue read (POLLERR).
This adds a heuristic to read the errqueue should we get no data from
a normal socket read.