Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use random udp source port for GTP-C requests #273

Merged
merged 3 commits into from
Dec 4, 2020
Merged

use random udp source port for GTP-C requests #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce37059
add dedicated second socket to GTP C port for sending requests
RoadRunnr Dec 2, 2020
afa5e5a
make the split GTP-C setup configurable
RoadRunnr Dec 3, 2020
54cb0f7
CT: add test for single socket setup
RoadRunnr Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/ergw.hrl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
key :: term(),
socket :: #socket{},
info :: #gtp_socket_info{},
src :: atom(),
ip :: inet:ip_address(),
port :: 0 .. 65535,
version :: 'v1' | 'v2',
Expand Down
135 changes: 83 additions & 52 deletions src/ergw_gtp_c_socket.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@

%% API
-export([start_link/1,
info/1, send/4, send_response/3,
send_request/6, send_request/7, resend_request/2]).
info/1, send/5, send_response/3,
send_request/7, send_request/8, resend_request/2]).
-export([get_seq_no/2, get_uniq_id/1]).

%% gen_server callbacks
-export([init/1, handle_call/3, handle_cast/2, handle_info/2,
terminate/2, code_change/3]).

-ifdef(TEST).
-export([get_request_q/1, get_response_q/1, send_reply/2, make_send_req/7]).
-export([get_request_q/1, get_response_q/1, send_reply/2, make_send_req/8]).

-define(MAKE_SEND_REQ, ?MODULE:make_send_req).
-else.
Expand All @@ -45,7 +45,8 @@
gtp_socket :: #socket{},
info :: #gtp_socket_info{},

socket :: socket:socket(),
recv_socket :: socket:socket(),
send_socket :: socket:socket(),
burst_size = 1 :: non_neg_integer(),

v1_seq_no = 0 :: v1_sequence_number(),
Expand All @@ -59,6 +60,7 @@

-record(send_req, {
req_id :: term(),
src :: gtp | any,
address :: inet:ip_address(),
port :: inet:port_number(),
t3 :: non_neg_integer(),
Expand Down Expand Up @@ -86,25 +88,25 @@ start_link(SocketOpts) ->
info(Socket) ->
call(Socket, info).

send(Socket, IP, Port, Data) ->
cast(Socket, {send, IP, Port, Data}).
send(Socket, Src, IP, Port, Data) ->
cast(Socket, {send, Src, IP, Port, Data}).

send_response(#request{socket = Socket} = ReqKey, Msg, DoCache) ->
message_counter(tx, ReqKey, Msg),
Data = gtp_packet:encode(Msg),
cast(Socket, {send_response, ReqKey, Data, DoCache}).

%% send_request/7
send_request(Socket, DstIP, DstPort, T3, N3, Msg, CbInfo) ->
%% send_request/8
send_request(Socket, Src, DstIP, DstPort, T3, N3, Msg, CbInfo) ->
?LOG(debug, "~p: gtp_socket send_request to ~s(~p):~w: ~p",
[self(), inet:ntoa(DstIP), DstIP, DstPort, Msg]),
cast(Socket, ?MAKE_SEND_REQ(undefined, DstIP, DstPort, T3, N3, Msg, CbInfo)).
cast(Socket, ?MAKE_SEND_REQ(undefined, Src, DstIP, DstPort, T3, N3, Msg, CbInfo)).

%% send_request/6
send_request(Socket, DstIP, DstPort, ReqId, Msg, CbInfo) ->
%% send_request/7
send_request(Socket, Src, DstIP, DstPort, ReqId, Msg, CbInfo) ->
?LOG(debug, "~p: gtp_socket send_request ~p to ~s:~w: ~p",
[self(), ReqId, inet:ntoa(DstIP), DstPort, Msg]),
cast(Socket, ?MAKE_SEND_REQ(ReqId, DstIP, DstPort, ?T3 * 2, 0, Msg, CbInfo)).
cast(Socket, ?MAKE_SEND_REQ(ReqId, Src, DstIP, DstPort, ?T3 * 2, 0, Msg, CbInfo)).

resend_request(Socket, ReqId) ->
cast(Socket, {resend_request, ReqId}).
Expand Down Expand Up @@ -137,10 +139,21 @@ call(#socket{pid = Handler}, Request) ->
%%% gen_server callbacks
%%%===================================================================

init(#{name := Name, ip := IP, burst_size := BurstSize} = SocketOpts) ->
init(#{name := Name, ip := IP, burst_size := BurstSize,
split_sockets := SplitSockets} = SocketOpts) ->
process_flag(trap_exit, true),

{ok, Socket} = ergw_gtp_socket:make_gtp_socket(IP, ?GTP1c_PORT, SocketOpts),
{ok, RecvSocket} = ergw_gtp_socket:make_gtp_socket(IP, ?GTP1c_PORT, SocketOpts),
SendSocket =
case SplitSockets of
true ->
{ok, SndSocket} = ergw_gtp_socket:make_gtp_socket(IP, 0, SocketOpts),
self() ! {'$socket', SndSocket, select, undefined},
SndSocket;
false ->
RecvSocket
end,

VRF = case SocketOpts of
#{vrf := VRF0} when is_binary(VRF0) ->
VRF0;
Expand All @@ -159,7 +172,8 @@ init(#{name := Name, ip := IP, burst_size := BurstSize} = SocketOpts) ->
gtp_socket = GtpSocket,
info = #gtp_socket_info{vrf = VRF, ip = IP},

socket = Socket,
recv_socket = RecvSocket,
send_socket = SendSocket,
burst_size = BurstSize,

v1_seq_no = 0,
Expand All @@ -170,7 +184,7 @@ init(#{name := Name, ip := IP, burst_size := BurstSize} = SocketOpts) ->

unique_id = rand:uniform(16#ffffffff)
},
self() ! {'$socket', Socket, select, undefined},
self() ! {'$socket', RecvSocket, select, undefined},
{ok, State}.

handle_call(info, _From, #state{info = Info} = State) ->
Expand All @@ -197,9 +211,9 @@ handle_call(Request, _From, State) ->
?LOG(error, "handle_call: unknown ~p", [Request]),
{reply, ok, State}.

handle_cast({send, IP, Port, Data}, State)
handle_cast({send, Src, IP, Port, Data}, State)
when is_binary(Data) ->
sendto(IP, Port, Data, State),
sendto(Src, IP, Port, Data, State),
{noreply, State};

handle_cast({send_response, ReqKey, Data, DoCache}, State0)
Expand Down Expand Up @@ -255,19 +269,29 @@ handle_info({timeout, TRef, requests}, #state{requests = Requests} = State) ->
handle_info({timeout, TRef, responses}, #state{responses = Responses} = State) ->
{noreply, State#state{responses = ergw_cache:expire(TRef, Responses)}};

handle_info({'$socket', Socket, select, Info}, #state{socket = Socket} = State) ->
handle_input(Socket, Info, State);
handle_info({'$socket', Socket, select, Info}, #state{recv_socket = Socket} = State) ->
handle_input(Socket, gtp, Info, State);

handle_info({'$socket', Socket, abort, Info}, #state{socket = Socket} = State) ->
handle_input(Socket, Info, State);
handle_info({'$socket', Socket, abort, Info}, #state{recv_socket = Socket} = State) ->
handle_input(Socket, gtp, Info, State);

handle_info({'$socket', Socket, select, Info}, #state{send_socket = Socket} = State) ->
handle_input(Socket, any, Info, State);

handle_info({'$socket', Socket, abort, Info}, #state{send_socket = Socket} = State) ->
handle_input(Socket, any, Info, State);

handle_info(Info, State) ->
?LOG(error, "~s:handle_info: unknown ~p, ~p",
[?MODULE, Info, State]),
{noreply, State}.

terminate(_Reason, #state{socket = Socket} = _State) ->
socket:close(Socket),
terminate(_Reason, #state{recv_socket = RecvSocket, send_socket = SendSocket} = _State) ->
socket:close(RecvSocket),
case SendSocket of
RecvSocket -> ok;
_ -> socket:close(SendSocket)
end,
ok.

code_change(_OldVsn, State, _Extra) ->
Expand Down Expand Up @@ -315,9 +339,10 @@ new_sequence_number(#gtp{version = v2, type = Type} = Msg,
family({_,_,_,_}) -> inet;
family({_,_,_,_,_,_,_,_}) -> inet6.

make_send_req(ReqId, Address, Port, T3, N3, Msg, CbInfo) ->
make_send_req(ReqId, Src, Address, Port, T3, N3, Msg, CbInfo) ->
#send_req{
req_id = ReqId,
src = Src,
address = Address,
port = Port,
t3 = T3,
Expand All @@ -327,33 +352,33 @@ make_send_req(ReqId, Address, Port, T3, N3, Msg, CbInfo) ->
send_ts = erlang:monotonic_time()
}.

make_request(ArrivalTS, IP, Port, Msg, #state{gtp_socket = Socket, info = Info}) ->
ergw_gtp_socket:make_request(ArrivalTS, IP, Port, Msg, Socket, Info).
make_request(ArrivalTS, Src, IP, Port, Msg, #state{gtp_socket = Socket, info = Info}) ->
ergw_gtp_socket:make_request(ArrivalTS, Src, IP, Port, Msg, Socket, Info).

handle_input(Socket, Info, #state{burst_size = BurstSize} = State) ->
handle_input(Socket, Info, 0, BurstSize, State).
handle_input(Socket, Src, Info, #state{burst_size = BurstSize} = State) ->
handle_input(Socket, Src, Info, 0, BurstSize, State).

handle_input(Socket, _Info, Cnt, Max, State0)
handle_input(Socket, _Src, _Info, Cnt, Max, State0)
when Cnt >= Max ->
%% break the loop and restart
self() ! {'$socket', Socket, select, undefined},
{noreply, State0};

handle_input(Socket, Info, Cnt, Max, State0) ->
handle_input(Socket, Src, Info, Cnt, Max, State0) ->
case socket:recvfrom(Socket, 0, [], nowait) of
{error, _} ->
State = handle_err_input(Socket, State0),
handle_input(Socket, Info, Cnt + 1, Max, State);
handle_input(Socket, Src, Info, Cnt + 1, Max, State);

{ok, {#{addr := IP, port := Port}, Data}} ->
ArrivalTS = erlang:monotonic_time(),
State = handle_message(ArrivalTS, IP, Port, Data, State0),
handle_input(Socket, Info, Cnt + 1, Max, State);
State = handle_message(ArrivalTS, Src, IP, Port, Data, State0),
handle_input(Socket, Src, Info, Cnt + 1, Max, State);

{select, _SelectInfo} when Cnt == 0 ->
%% there must be something in the error queue
State = handle_err_input(Socket, State0),
handle_input(Socket, Info, Cnt + 1, Max, State);
handle_input(Socket, Src, Info, Cnt + 1, Max, State);

{select, _SelectInfo} ->
{noreply, State0}
Expand Down Expand Up @@ -427,50 +452,50 @@ handle_err_input(Socket, State) ->
end,
State.

handle_message(ArrivalTS, IP, Port, Data, #state{gtp_socket = Socket} = State0) ->
handle_message(ArrivalTS, Src, IP, Port, Data, #state{gtp_socket = Socket} = State0) ->
try gtp_packet:decode(Data, #{ies => binary}) of
Msg = #gtp{} ->
%% TODO: handle decode failures

?LOG(debug, "handle message: ~p", [{IP, Port,
?LOG(debug, "handle message: ~p", [{Src, IP, Port,
State0#state.gtp_socket,
Msg}]),
ergw_prometheus:gtp(rx, Socket, IP, Msg),
handle_message_1(ArrivalTS, IP, Port, Msg, State0)
handle_message_1(ArrivalTS, Src, IP, Port, Msg, State0)
catch
Class:Error ->
ergw_prometheus:gtp_error(rx, Socket, 'malformed-requests'),
?LOG(error, "GTP decoding failed with ~p:~p for ~p", [Class, Error, Data]),
State0
end.

handle_message_1(_, _, _, #gtp{version = Version}, #state{gtp_socket = Socket} = State)
handle_message_1(_, _, _, _, #gtp{version = Version}, #state{gtp_socket = Socket} = State)
when Version /= v1 andalso Version /= v2 ->
ergw_prometheus:gtp_error(rx, Socket, 'version-not-supported'),
State;

handle_message_1(ArrivalTS, IP, Port, #gtp{type = echo_request} = Msg, State) ->
ReqKey = make_request(ArrivalTS, IP, Port, Msg, State),
handle_message_1(ArrivalTS, Src, IP, Port, #gtp{type = echo_request} = Msg, State) ->
ReqKey = make_request(ArrivalTS, Src, IP, Port, Msg, State),
gtp_path:handle_request(ReqKey, Msg),
State;

handle_message_1(ArrivalTS, IP, Port, #gtp{version = Version, type = MsgType} = Msg, State) ->
handle_message_1(ArrivalTS, Src, IP, Port, #gtp{version = Version, type = MsgType} = Msg, State) ->
Handler =
case Version of
v1 -> gtp_v1_c;
v2 -> gtp_v2_c
end,
case Handler:gtp_msg_type(MsgType) of
response ->
handle_response(ArrivalTS, IP, Port, Msg, State);
handle_response(ArrivalTS, Src, IP, Port, Msg, State);
request ->
ReqKey = make_request(ArrivalTS, IP, Port, Msg, State),
ReqKey = make_request(ArrivalTS, Src, IP, Port, Msg, State),
handle_request(ReqKey, Msg, State);
_ ->
State
end.

handle_response(ArrivalTS, IP, _Port, Msg, #state{gtp_socket = Socket} = State0) ->
handle_response(ArrivalTS, _Src, IP, _Port, Msg, #state{gtp_socket = Socket} = State0) ->
SeqId = ergw_gtp_socket:make_seq_id(Msg),
{Req, State} = take_request(SeqId, State0),
case Req of
Expand All @@ -486,12 +511,12 @@ handle_response(ArrivalTS, IP, _Port, Msg, #state{gtp_socket = Socket} = State0)
State
end.

handle_request(#request{ip = IP, port = Port} = ReqKey, Msg,
handle_request(#request{src = Src, ip = IP, port = Port} = ReqKey, Msg,
#state{gtp_socket = Socket, responses = Responses} = State) ->
case ergw_cache:get(cache_key(ReqKey), Responses) of
{value, Data} ->
ergw_prometheus:gtp(rx, Socket, IP, Msg, duplicate),
sendto(IP, Port, Data, State);
sendto(Src, IP, Port, Data, State);

_Other ->
?LOG(debug, "HandleRequest: ~p", [_Other]),
Expand Down Expand Up @@ -520,10 +545,16 @@ take_request(SeqId, #state{pending = PendingIn} = State) ->
{Req, State#state{pending = PendingOut}}
end.

sendto(RemoteIP, Port, Data, #state{socket = Socket}) ->
socket(gtp, #state{recv_socket = Socket}) ->
Socket;
socket(any, #state{send_socket = Socket}) ->
Socket.

sendto(Src, RemoteIP, Port, Data, State) ->
Dest = #{family => family(RemoteIP),
addr => RemoteIP,
port => Port},
Socket = socket(Src, State),
case socket:sendto(Socket, Data, Dest, nowait) of
ok -> ok;
Other ->
Expand All @@ -537,8 +568,8 @@ send_reply({M, F, A}, Reply) ->
send_request_reply(#send_req{cb_info = CbInfo}, Reply) ->
send_reply(CbInfo, Reply).

send_request(#send_req{address = DstIP, port = DstPort, data = Data} = SendReq, State0) ->
sendto(DstIP, DstPort, Data, State0),
send_request(#send_req{src = Src, address = DstIP, port = DstPort, data = Data} = SendReq, State0) ->
sendto(Src, DstIP, DstPort, Data, State0),
State = start_request(SendReq, State0),
request_q_in(SendReq, State).

Expand All @@ -557,8 +588,8 @@ enqueue_response(ReqKey, Data, DoCache,
enqueue_response(_ReqKey, _Data, _DoCache, State) ->
State.

do_send_response(#request{ip = IP, port = Port} = ReqKey, Data, DoCache, State) ->
sendto(IP, Port, Data, State),
do_send_response(#request{src = Src, ip = IP, port = Port} = ReqKey, Data, DoCache, State) ->
sendto(Src, IP, Port, Data, State),
measure_response(ReqKey),
enqueue_response(ReqKey, Data, DoCache, State).

Expand Down
Loading