Skip to content

Create only add snapshot operation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create only add snapshot operation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizableOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ public enum PolarisAuthorizableOperation {
LOAD_TABLE(TABLE_READ_PROPERTIES),
LOAD_TABLE_WITH_READ_DELEGATION(TABLE_READ_DATA),
LOAD_TABLE_WITH_WRITE_DELEGATION(TABLE_WRITE_DATA),
UPDATE_TABLE_ONLY_ADD_SNAPSHOT(TABLE_WRITE_PROPERTIES),
UPDATE_TABLE(TABLE_WRITE_PROPERTIES),
UPDATE_TABLE_FOR_STAGED_CREATE(TABLE_CREATE),
DROP_TABLE_WITHOUT_PURGE(TABLE_DROP),
Expand Down
6 changes: 5 additions & 1 deletion ...rvice/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,11 @@ private UpdateTableRequest applyUpdateFilters(UpdateTableRequest request) {

public LoadTableResponse updateTable(
TableIdentifier tableIdentifier, UpdateTableRequest request) {
PolarisAuthorizableOperation op = PolarisAuthorizableOperation.UPDATE_TABLE;
boolean isOnlyAddSnapshot = request.updates().stream()
.allMatch(update -> update instanceof MetadataUpdate.AddSnapshot);
PolarisAuthorizableOperation op = isOnlyAddSnapshot
? PolarisAuthorizableOperation.UPDATE_TABLE_ONLY_ADD_SNAPSHOT
: PolarisAuthorizableOperation.UPDATE_TABLE;
authorizeBasicTableLikeOperationOrThrow(
op, PolarisEntitySubType.ICEBERG_TABLE, tableIdentifier);

Expand Down
Loading