Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy failing when skip_cleanup: true removed (using cleanup: false implicitly or explicitly) #1138

Closed
myii opened this issue Nov 16, 2019 · 3 comments
Closed

Deploy failing when skip_cleanup: true removed (using cleanup: false implicitly or explicitly) #1138

myii opened this issue Nov 16, 2019 · 3 comments

Comments

@myii
Copy link

myii commented Nov 16, 2019

Opted in to the new beta feature after finding out about it:

All changes working well but not being able to remove skip_cleanup: true and rely on cleanup: false implicitly or explicitly.
@myii
Copy link
Author

myii commented Nov 16, 2019 •
edited
Loading

Also tested on travis-ci.com with the same problem:

@myii myii mentioned this issue Nov 16, 2019
Merged
@svenfuchs
Copy link
Contributor

svenfuchs commented Nov 18, 2019 •
edited
Loading

@myii sorry about the confusion here. the Build Config Validation feature normalizes your config in such a way that it is assumed that you are using dpl v2, too (https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release). we are soon going to make v2 the default version.

in the meantime, could you please add this to to your config:

deploy:
  provider: script
  edge: true

@myii
Copy link
Author

myii commented Nov 18, 2019

@svenfuchs OK, thanks for the info, I'll do that.

myii added a commit to myii/ssf-formula that referenced this issue Nov 18, 2019
@myii
ci(travis): opt-in to dpl v2 to complete build config validation
c11108f 
* travis-ci/dpl#1138 (comment)
* https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release
myii added a commit to myii/ssf-formula that referenced this issue Nov 18, 2019
@myii
ci(travis): opt-in to dpl v2 to complete build config validation
1af7a81 
* travis-ci/dpl#1138 (comment)
* https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release
myii added a commit to myii/ssf-formula that referenced this issue Nov 18, 2019
@myii
feat(travis): opt-in to dpl v2 to complete build config validation
7c905e2 
* travis-ci/dpl#1138 (comment)
* https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release
* https://docs.travis-ci.com/user/build-config-validation
@myii myii mentioned this issue Nov 18, 2019
Merged
myii added a commit to myii/ssf-formula that referenced this issue Nov 18, 2019
@myii
feat(travis): opt-in to dpl v2 to complete build config validation
ad6414e 
* travis-ci/dpl#1138 (comment)
* https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release
* https://docs.travis-ci.com/user/build-config-validation
@myii myii mentioned this issue Nov 18, 2019
Merged
myii pushed a commit to myii/ssf-formula that referenced this issue Nov 19, 2019
@semantic-release-bot
chore(release): 1.57.0 [skip ci]
30c4f55 
# [1.57.0](v1.56.1...v1.57.0) (2019-11-19)

### Continuous Integration

* **travis:** opt-in to `dpl v2` to complete build config validation ([1af7a81](1af7a81)), closes [/github.com/travis-ci/dpl/issues/1138#issuecomment-554988130](https://github.com//github.com/travis-ci/dpl/issues/1138/issues/issuecomment-554988130)

### Features

* **rabbitmq:** add `latest` suite ([8df7a31](8df7a31)), closes [/github.com/saltstack-formulas/rabbitmq-formula/pull/53#issuecomment-553480289](https://github.com//github.com/saltstack-formulas/rabbitmq-formula/pull/53/issues/issuecomment-553480289)
myii added a commit to myii/ssf-formula that referenced this issue Nov 19, 2019
@myii
feat(travis): opt-in to dpl v2 to complete build config validation
b0e36eb 
* travis-ci/dpl#1138 (comment)
* https://blog.travis-ci.com/2019-08-27-deployment-tooling-dpl-v2-preview-release
* https://docs.travis-ci.com/user/build-config-validation
myii pushed a commit to myii/ssf-formula that referenced this issue Nov 20, 2019
@semantic-release-bot
chore(release): 1.58.0 [skip ci]
b54e4d3 
# [1.58.0](v1.57.0...v1.58.0) (2019-11-20)

### Features

* **travis:** opt-in to `dpl v2` to complete build config validation ([b0e36eb](b0e36eb)), closes [/github.com/travis-ci/dpl/issues/1138#issuecomment-554988130](https://github.com//github.com/travis-ci/dpl/issues/1138/issues/issuecomment-554988130)
@benmelz benmelz mentioned this issue Aug 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenfuchs @myii