Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.9.3. #1295

Closed
wants to merge 1 commit into from
Closed

Bump Go version to 1.9.3. #1295

wants to merge 1 commit into from

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Jan 23, 2018

@BanzaiMan
Copy link
Contributor

Spec needs fixing.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jan 23, 2018

Looks like not a spec, but something else should be fixed: 1.9.x should resolve into 1.9.3, not 1.9.1.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jan 23, 2018

I guess it's gimme's .testdata. But now I'm totally confused.

@BanzaiMan
Copy link
Contributor

Well, the file is here: https://github.com/travis-ci/gimme/blob/master/.testdata/sample-binary-linux

@meatballhat Could you shine a light on how we are supposed to update the default Go version?

@AlekSi
Copy link
Contributor Author

AlekSi commented Jan 23, 2018

I already sent travis-ci/gimme#120. But the fact that travis-build depends on gimme's testdata sounds very strange for me. See also travis-ci/gimme#110.

@philpennock
Copy link

travis-ci/gimme change updating testdata approved and merged. Yinz should be good to trigger a rebuild of this one now, to confirm it works.

@AlekSi
Copy link
Contributor Author

AlekSi commented Jan 25, 2018

I rebased my branch to trigger a build, but it still fails. And it shows old values.

'1.9.3' => '1.9.3',
'1.9.x' => '1.9.3',
'1.x' => '1.9.3',
'1.x.x' => '1.9.3',

This comment was marked as spam.

@AlekSi
Copy link
Contributor Author

AlekSi commented Feb 8, 2018

Closed in favor of #1307.

@BanzaiMan BanzaiMan closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants