Automate Go and GHC version upgrades #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually updating public/version-aliases/go.json with each Go release, we update the necessary data using data provided by the Go lang source itself. Notice that some finessing is necessary because Go lang's git repository does not retrun valid JSON data. See golang/go#25548 (comment)
Instead of relying on a future env var
${dirty[@]} results in embedded string termination, which results
in command error (with bad pathspec)
|
Specs need fixing. |
|
Note that if Travis were to pull in gimme 1.5.0, you could just ask gimme to |
|
I think this is no longer necessary. @meatballhat Could you comment? |
|
@BanzaiMan I think this can be safely closed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we rely on travis-ci/gimme to provide the most up-to-date list of Go releases to use. This requires manual intervention whenever there is a new release. (For example, Go 1.10.2 was released on May 1, 2018, 24 days ago, but we have users asking for it now travis-ci/travis-ci#9652.)
This is cumbersome and unnecessary.
We automate this process by consulting https://go.googlesource.com/go/+refs?format=JSON and discovering all most recent releases 1.2.x and up.
Then, in exactly one job which runs the
assets:precompileRake task, we check if any of the files inpublic/version-aliasesis updated, and if so, create a Pull Request to this repository to be reviewed and merged.