Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finishing a build that has a canceled job on a stage #125

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

svenfuchs
Copy link
Contributor

@svenfuchs svenfuchs deployed to org-staging August 29, 2017 11:49 Active
@svenfuchs svenfuchs merged commit a4b4e70 into master Aug 29, 2017
@ljharb
Copy link

ljharb commented Aug 29, 2017

Did you intend to close the linked issue?

@svenfuchs
Copy link
Contributor Author

@ljharb lol, no! thanks for the pointer ❤️

In this case, however, since @BanzaiMan already locked it, i guess it's fine. My tentative plan is to open a new "beta feature feedback issue" once I ship iteration 2 (should happen soonish), and then also include something like an FAQ at the very top (so we don't get all the already answered questions all over).

@ljharb
Copy link

ljharb commented Aug 29, 2017

Sounds good. Please post it in the original issue so subscribers get a notification :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Stages: Flexible and practical Continuous Delivery pipelines
2 participants