Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Commit

Permalink
Workaround for Xcode 13.4 RC bug
Browse files Browse the repository at this point in the history
  • Loading branch information
@travis-mark
travis-mark committed Mar 24, 2023
1 parent f1d6811 commit 0158547
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
16 changes: 16 additions & 0 deletions ios/Podfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,21 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ
platform :ios, min_ios_version_supported
install! 'cocoapods', :deterministic_uuids => false

# Force pods to match minimum iOS version for React Native
# Fixes build issue on Xcode Cloud where some pods
# Use iOS 12 calls despite being set as iOS 11
def __apply_Xcode_14_3_RC_post_install_workaround(installer)
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
current_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET']
minimum_target = min_ios_version_supported
if current_target.to_f < minimum_target.to_f
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = minimum_target
end
end
end
end

target 'LearnReactNative' do
config = use_native_modules!

Expand Down Expand Up @@ -33,6 +48,7 @@ target 'LearnReactNative' do
post_install do |installer|
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
__apply_Xcode_14_3_RC_post_install_workaround(installer)
end
end

Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,6 @@ SPEC CHECKSUMS:
Yoga: 79dd7410de6f8ad73a77c868d3d368843f0c93e0
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: cb6e62e6487171d1eb6538cf012f783233fac94d
PODFILE CHECKSUM: b16880a4841e127a721876a9fbc673238de76d94

COCOAPODS: 1.11.3

26 comments on commit 0158547

@SaimouliBandari
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @travis-mark

@fatihyildizhan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it worked.

@Harshith-Karkera
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it worked.

@BilalSattar99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me @travis-mark can you help, I am using Xcode 14.3
image

@aike19115
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It works 👌

@berkayakin
Copy link

@berkayakin berkayakin commented on 0158547 Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error:

The following build commands failed:
        CompileC /Users/berkayakin/Library/Developer/Xcode/DerivedData/Inbox-ccxzqbfipumvtuceswdisyxkfkzt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/arm64/HHWheelTimer.o /Users/berkayakin/Desktop/dev/InboxMobileReactNative/ios/Pods/RCT-Folly/folly/io/async/HHWheelTimer.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods')

I do not use the following line as it causes an issue with one of the dependencies:
__apply_Xcode_12_5_M1_post_install_workaround(installer)

I am on an M1 Pro MacBook.

@RaviKiranMakala
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me @travis-mark can you help, I am using Xcode 14.3 image

I am also facing same issue. Did you found any work around ?

@phuongwd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me @travis-mark can you help, I am using Xcode 14.3 image

This issue is related to the Firebase,
I updated the Firebase/Messaging to 8.12.1. and "@react-native-firebase/app": "14.3.2",

Screenshot 2023-04-03 at 20 26 07

@travis-mark
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is related to the Firebase

I would open an issue at the firebase repo, your problem appears to be unrelated.

@osikes
Copy link

@osikes osikes commented on 0158547 Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me

@fatihyildizhan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/facebook/react-native/releases/tag/v0.71.6

fix released

@vaibhavshah0201
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @travis-mark it worked for mee !!!

But is is ok to touch Podfile?

@RogierZeebregts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @travis-mark it worked for mee !!!

But is is ok to touch Podfile?

That's totaly fine, to edit Podfile

@cankilinc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me

@RogierZeebregts
Copy link

@RogierZeebregts RogierZeebregts commented on 0158547 Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping React Native to 0.71.6 should this issue

@RaviKiranMakala
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me @travis-mark can you help, I am using Xcode 14.3 image

@BilalSattar99 , did you solved the issue?

@RilDev
Copy link

@RilDev RilDev commented on 0158547 Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, thank you!

@1mike12
Copy link

@1mike12 1mike12 commented on 0158547 May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jesus man can't believe this worked. This issue had nothign to do with firebase since I don't use it.

@DuongVNU
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, thank you!

@jonathanroze
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working! Thanks a lot.

@purrseus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked! Thanks!

@israromar
Copy link

@israromar israromar commented on 0158547 Jun 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/facebook/react-native/releases/tag/v0.71.6

fix released

version upgrade from v0.70.6 to v0.71.6 fixed it for me
thank you fatihyildizhan

@factedu
Copy link

@factedu factedu commented on 0158547 Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/facebook/react-native/releases/tag/v0.71.6
fix released

version upgrade from v0.70.6 to v0.71.6 fixed it for me thank you fatihyildizhan

Worked for me

@ezos86
Copy link

@ezos86 ezos86 commented on 0158547 Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked for me. Life saver. Thank you.

@a2345sooted
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my case, i had to downgrade react-native-screens from 3.23.0 to 3.19.0 and everything worked. I tried everything else. using react-native 0.72.3

@mowaisfarid
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berkayakin how do you resolve this?

Please sign in to comment.