start to convert goodwatch.py to python3 for #131 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, and email me your shipping address if you'd like to PCBs shipped your way. This PR takes care of the |
|
We could merge this if the first line kept the parser as |
tahnok
force-pushed
the
python3_goodwatch
branch
from
3a9bf9d
to
523b8f7
Compare
tahnok
changed the title
|
Thank you for the PCB offer, but I have an order in to a fab already. I've updated to keep the parser as python2 which should make a second PR to use bytes instead of strings easier to look over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a goodwatch to test this with, but python parses it without complaint