Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[green] USPS tracking now working #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[green] USPS tracking now working #9

wants to merge 2 commits into from

Conversation

zackshapiro
Copy link

  • Completely re-wrote the date method that was the source of many failures. The thing that was causing the error was a hardcoded look for a certain range. With the re-write, it looks for the month in the array and uses it's index as the starting value for the date. It then goes either 2 or 4 places deeper in the array to get the full date based on whether AM or PM is present in that index.
  • Re-wrote the description method to detect the description more simply. The format is always a description, followed by a comma, so I'm just splitting on the first comma. Tried this with a few data sets, works well. They never use commas in the description
  • Removed excess comma from city, state, zip. They now include it in the city string
  • In the location method, detecting whether or not the location is present. If not, returning an empty string for location.
  • Was unable to get specs to run, said there were zero specs when that's not true. Rewrote method to be more accurate in detection
  • Closes Does USPS require a password? #8
  • Still needs tagging update, will leave that to you @travishaynes

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28c on zackshapiro:0.7.6 into 1c8fd4c on travishaynes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28c on zackshapiro:0.7.6 into 1c8fd4c on travishaynes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28c on zackshapiro:0.7.6 into 1c8fd4c on travishaynes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.65%) when pulling 9dec4f9 on zackshapiro:0.7.6 into 1c8fd4c on travishaynes:master.

rewrote location to include multiple word locations like 'san francisco' or 'los angeles'
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.65%) when pulling d0e8ccb on zackshapiro:0.7.6 into 1c8fd4c on travishaynes:master.

@zackshapiro
Copy link
Author

@travishaynes Bumping this

@zackshapiro
Copy link
Author

Any action on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does USPS require a password?
2 participants