This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded all 'babel-' dependencies and various other dependencies that were still using babel 6. Then worked through the issues that came up:
Updated eslint to latest version that uses babel 7 and converted .eslintrc(s) from yaml to json.
Use strict now uses double quotes instead of single quotes; see this.
Ava was updated to a newer version that uses babel 7, it’s actually using rc1 since even version 0.25 was still using babel 6. For the tests this caused a change where the process.cwd() is now wherever the package.json is located when running tests; see this thread. This lead to changing all the tests config paths, removal of the ‘basic require with default webpack name’ test (for now, open to suggestions on how to re-add) and changing a lot of the expected fixture paths.
Expected fixtures are now double spaced to match generated output and paths that are replaced become double quoted, not sure why couldn’t find documentation on that one.