forked from vuejs/pinia
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge head #1
Merged
trchopan
merged 22 commits into
trchopan:usecase-for-function-style-in-define-store
from
vuejs:v2
Jul 2, 2022
Merged
Merge head #1
trchopan
merged 22 commits into
trchopan:usecase-for-function-style-in-define-store
from
vuejs:v2
Jul 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the getter name for full name in example of usage vuex inside the componets
I think this comma is unintended
Use the correct subdomain to link to the Vue 2 documentation. Since the switch to Vue 3 as the default Vue version, to access the Vue 2 documentation the `https://v2.vuejs.org` subdomain must be used.
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Correct typo on comment
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
On https://pinia.vuejs.org/core-concepts/ it is mentioned that "Naming the returned function use... is a convention across composables to make its usage idiomatic.". In this example though, the returned function is called `todos` as opposed to `useTodos`.
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Co-authored-by: liuyao <liuyao@liuyaodeiMac.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.