Use setup.cfg with adding python_requires #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use attr: pytd.__version__, we need to stop importing .client in __init__.py. This introduces incompatible change than benefit, so changes to write version number in setup.cfg explicitly.
chezou
commented
Feb 2, 2021
| @@ -1,3 +1,52 @@ | |||
| [metadata] | |||
| name = pytd | |||
| version = 1.4.0 | |||
There was a problem hiding this comment.
Unfortunately version = attr: pytd.__version__ doesn't work well while there was improvement for it
https://stackoverflow.com/questions/58202909/modulenotfounderror-when-using-setup-cfg-and-version-accessed-with-attr
pypa/setuptools#1753
|
Hmm, we hit |
chezou
changed the title
takuti
approved these changes
Feb 4, 2021
doc/contributing.rst
Outdated
Comment on lines
77
to
79
| .. code:: py | ||
|
|
||
| __version__ = "1.0.0" | ||
| version = 1.0.0 |
There was a problem hiding this comment.
Let's make it more interpretable as setup.cfg
.. code:: ini
[metadata]
name = pytd
version = 1.0.0
setup.py
Outdated
Comment on lines
7
to
9
| a shorter time. It eventually makes your day-to-day data analytics work more | ||
| efficient and productive. | ||
| """ |
There was a problem hiding this comment.
Since the config file no longer refers __doc__, we can delete the top-level statements.
|
Thanks, applied feedbacks on 865e9df |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to use setup.cfg instead of setup.py also adding
python_requires, describing explicit supported version for Python