-
Notifications
You must be signed in to change notification settings - Fork 7
Added Separate Contributors page #15
base: master
Are you sure you want to change the base?
Conversation
I don't understand. There shouldn't be any merge conflicts but I am unable to checkout your pr with GitHub CLI. Did you force push anything :D? |
I don't know. I first deleted my version of repo and then reforked. After that, made changes to the files. Then, made a pull request. All that was done by using GitHub.com cuz never tried using CLI. |
@velitasali one more thing. The hacktoberfest tag is not what is available here. It is "hacktoberfest-accepted" tag. |
Hm. Sure thing it would work if I cloned your repo or applied your changes as a patch. I will try one of those if nothing works. |
Thanks a lot for everything 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, it looks really nice apart from I am not showing up in the Android app section 😄
Also, could you give the image a static length (width and height) so that they could appear the same? object-fit: cover;
will make the images zoomed when they don't have even widths and heights.
I made some changes so that it would like the below images
Also, when zoomed it looks like the image below, probably due to giving the images wrong positioning argument. (position: relative maybe?)
This time it works cuz nothing changed to previous files and this is a simple page like(https://showndarya.github.io/Hacktoberfest/Contributors_Page_Source/).