Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Added Separate Contributors page #15

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mubashir-rehman
Copy link

This time it works cuz nothing changed to previous files and this is a simple page like(https://showndarya.github.io/Hacktoberfest/Contributors_Page_Source/).

Screenshot from 2020-10-07 21-37-46

@velitasali
Copy link
Member

I don't understand. There shouldn't be any merge conflicts but I am unable to checkout your pr with GitHub CLI. Did you force push anything :D?

@mubashir-rehman
Copy link
Author

I don't know. I first deleted my version of repo and then reforked. After that, made changes to the files. Then, made a pull request. All that was done by using GitHub.com cuz never tried using CLI.

@mubashir-rehman
Copy link
Author

@velitasali one more thing. The hacktoberfest tag is not what is available here. It is "hacktoberfest-accepted" tag.

@velitasali
Copy link
Member

I don't know. I first deleted my version of repo and then reforked.

Hm. Sure thing it would work if I cloned your repo or applied your changes as a patch. I will try one of those if nothing works.

@mubashir-rehman
Copy link
Author

Thanks a lot for everything 🙂

Copy link
Member

@velitasali velitasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it looks really nice apart from I am not showing up in the Android app section 😄

Also, could you give the image a static length (width and height) so that they could appear the same? object-fit: cover; will make the images zoomed when they don't have even widths and heights.

Screenshot from 2020-10-12 20-01-21

I made some changes so that it would like the below images

Screenshot from 2020-10-12 20-10-27
Screenshot from 2020-10-12 20-10-38

Screenshot from 2020-10-12 20-09-09

Also, when zoomed it looks like the image below, probably due to giving the images wrong positioning argument. (position: relative maybe?)

Screenshot from 2020-10-12 20-11-18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants