-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc compiler fixes #108
misc compiler fixes #108
Conversation
…ariables const/static
@MDeiml would be nice to have this merged (and a new release made) for Neovim, which now bundles these parsers. (Speaking of releases: I'm trying to push semver for parsers, which makes patch releases for changes -- like this one -- that do not affect queries ( |
Thanks. Sorry this took a while, am quite busy atm. |
@clason I'll try to stick to that. Feel free to mention me if I'm doing something wrong. |
@MDeiml It seems there has been quite a bit of activity here. The version Helix is currently using is |
@David-Else I'm sorry that I'm not very active at the moment. Not quite sure what you are aiming at? Do you mean I should update the helix configuration to use the new version of my parser (´0.1.6´)? I can create a PR. |
If you're busy I can help maintain a healthy release cycle/manage issues @MDeiml (as I do for all upstream grammars) |
@MDeiml Yes, that is what I had in mind :) |
@amaanq that would be awesome if the offer is still standing. I started full time working recently (was a student before) and don't really have time to do everything that I want to with this repo. Also got really bad at responding to issues 😅. |
Of course! Though I'm a bit busier now with school and stuff - but I'm happy to maintain it |
I guess you would need some privileges for the repo? |
Yep, you'd add me as a collaborator to the repo |
@MDeiml could you transfer this project to either @amaanq or me and we can add it to the https://github.com/tree-sitter-grammars org? |
If you want, of course. You'd keep write (but not admin) access, but you'd have people helping with routine maintenance and get a bunch of workflows for free ;) I'd also make it easier to adapt to the big upcoming changes in the tree-sitter ecosystem. |
Most of them have to do with implicit casts - and sometimes comparing items of two different types of sizes can cause them to be stuck in loops if the bigger item is a number the smaller one can never be
The first commit clearly shows the useful changes, then I just tidied up formatting to be consistent