Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access to source bytes and charset of a tree #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add access to source bytes and charset of a tree #65

wants to merge 3 commits into from

Conversation

Emmeral
Copy link

@Emmeral Emmeral commented Dec 16, 2024

This change avoids unnecessary conversions if users of the library want to work with the raw source bytes instead of a parsed string.

@ObserverOfTime
Copy link
Member

I don't think we want this.

@Emmeral
Copy link
Author

Emmeral commented Dec 17, 2024

Why do you think so?
This would avoid some unnecessary UTF-8 to UTF-16 conversion if they are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emmeral @ObserverOfTime