Use C++14 to allow building for Electron 11 on MacOS #83
Conversation
|
@maxbrunsfeld Could this be merged and released? A timely change for me. |
|
This is just necessary for recent electron versions (v11, v12) |
|
Right, for those who use electron v11+, here is the manual instruction to rebuild this module: https://github.com/Symbolk/somanyconflicts#known-issues |
|
👍, and I think not merging this might slow progress on using Electron 11 in the Atom text editor. Might have to fork this package for Atom just to get it building in Electron 11. |
|
@maxbrunsfeld What could be holding back this PR from getting merged? As @DeeDeeG has stated this currently blocks Atom from upgrading to electron version 11.4.7. |
| @@ -31,7 +31,7 @@ | |||
| "-std=c++0x", | |||
| ], | |||
| 'xcode_settings': { | |||
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', | |||
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++14', | |||
There was a problem hiding this comment.
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++14', | |
| 'CLANG_CXX_LANGUAGE_STANDARD': 'c++17', |
| @@ -31,7 +31,7 @@ | |||
| "-std=c++0x", | |||
There was a problem hiding this comment.
| "-std=c++0x", | |
| "-std=c++17", |
|
After being torture by native module (node-gyp and electron-rebuild) for months, I finally switched to wasm of treesitter, and it seems working fine: https://github.com/Symbolk/somanyconflicts Maybe this solution helps some of you. |
|
This PR can be closed because #92 (merged) did the same thing. |
Fixes #82.