Fixes #186
Merged
Fixes #186
+141,356
−90,225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an identifier like `-d` is on the RHS of a binary expression, parsing can fail
amaanq
force-pushed
the
fixes
branch
8 times, most recently
from
8fe769b to
25505ef
Compare
amaanq
force-pushed
the
fixes
branch
2 times, most recently
from
9cbc896 to
3ac494f
Compare
Co-authored-by: Nathan Sobo <nathan@zed.dev>
|
You're a legend mate |
This was referenced Aug 18, 2023
Merged
mournfully
added a commit
to mournfully/dotfiles
that referenced
this pull request
Aug 21, 2023
[Wrong parsing for `${!#}` · Issue #160 · tree-sitter/tree-sitter-bash](tree-sitter/tree-sitter-bash#160)
> Same problem here, with a similar variable replacement:
> `display="${display%|*}"`
> It makes the syntax broken for the rest of the file
[Fixes by amaanq · Pull Request #186 · tree-sitter/tree-sitter-bash](tree-sitter/tree-sitter-bash#186)
[Drop dependency on `bash-parser` · Issue #72 · webpro/knip](webpro-nl/knip#72)
> Since tree-sitter-bash@0.20.0 was released the other day I've pulled the
> trigger here as well. Would deserve either a major bump or just a patch
> release. As I think it shouldn't cause friction anywhere I opted for the
> latter (I do expect an occasional issue around arguments w/ quotes here
> and there, let's see).
>
> 🚀 This issue has been resolved in v2.19.6. See Release 2.19.6 for
> release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done w/ this, but leaving it up so I know which issues I fixed already (been 2 weeks)Supersedes #55
Supersedes #126
Closes #42
Closes #50
Closes #127
Closes #150
Closes #151
Closes #159
Closes #160
Closes #161
Closes #164
Closes #165
Closes #166
Closes #169
Closes #172
Closes #177
Closes #185