Fix preproc alternatives (elif, elifdef, else) #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are two functions ("elseBlock" and "elifBlock") that are used to generate alternatives (i.e. "#elif", "#elifdef", "#else").
More precisely, "elseBlock" generates "#else" and "#elif" nodes, and elifBlock generates "#elifdef" nodes.
The "#ifdef" is currently the only node offering a choice between elseBlock and elifBlock. Other conditional directives only allow elseBlock and thus do not offer the possiblity to have (for example) a "#if" followed by a "#elifdef".
Concretely, consider the following code:
This is currently parsed as a preproc_call
I can't think about any reason to disallow this behavior so I suggest to merge both function into a single one that generate all possible alternatives.
For the given example, this would result in
This commit also adds a test to check for regression