Updates

[amaanq]

Closes #234

[amaanq]

/cc @calebdw you're probably interested 😁

[calebdw]

@amaanq, thanks!

I guess I was missing the token.immediate in the string_content rule...

I have a few questions though:

• it looks like you removed the parse examples script...is there any way to run this outside of ci?
• there seems to be a lot of string_contents in the added testcase:

              (string
                (string_content)
                (string_content)
                (string_content)
                (string_content)
                (string_content)
                (string_content)
                (string_content)
                (escape_sequence)
                (string_content)
                (string_content))

  but should they not be condensed into a single node on either side of the escape sequence?

              (string
                (string_content)
                (escape_sequence)
                (string_content))

• it looks like all of the build scripts in the package.json were replaced by the prebuildify? If so that's pretty neat

[amaanq]

huh good point, I'll look at the string stuff in a bit

as to running examples outside of ci, no not really, since it was just cluttering the repo imo - if CI fails there's an option to make it upload the failed files (check example in parse-action repo), and so you can just download it from there - otherwise for local dev you can just copy the git clone commands in the ci file, and run ts p examples/**/*.php -q

yeah prebuildify is very nice, esp now that we've moved to napi from nan