feat: support php 8.4 and other improvements #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
php84
branch
4 times, most recently
from
288e747
to
1cc88cc
Compare
This was referenced Jun 7, 2024
|
nice, I'll take a look soon |
|
BTW @amaanq did you see my email? I tried to contact you on gmail but no answer :( |
amaanq
approved these changes
Aug 17, 2024
|
Bumping to 0.23.0 is fine, I only ask that you do that when I release 0.23.0 upstream (soon) (amended with generate optimization on master) |
|
thanks a ton again @calebdw, and I'm really sorry for taking a while 😬 |
|
No worries! Thanks for looking at it! |
Ablyakim
added a commit
to Ablyakim/nvim-treesitter-textobjects
that referenced
this pull request
Aug 20, 2024
- Renamed `anonymous_function_creation_expression` to `anonymous_function` to align with the upstream change in tree-sitter-php (see tree-sitter/tree-sitter-php#247).
kiyoon
pushed a commit
to nvim-treesitter/nvim-treesitter-textobjects
that referenced
this pull request
Aug 20, 2024
- Renamed `anonymous_function_creation_expression` to `anonymous_function` to align with the upstream change in tree-sitter-php (see tree-sitter/tree-sitter-php#247).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
Changes:
newwithout parenthesesanonymous_classrule_variable_name=>_simple_variableto match php parser_class_type_designator=>_class_name_referenceto match php parserby_refdefinition_identifierand_namerules_dereferencable_scalarrule to match php parsernamespace_name_as_prefix, usesprefixfieldnamespace_aliasing_clause, usesaliasfieldnamespace_use_group_clause, now usesnamespace_use_clauseinsidenamespace_use_groupanonymous_function_creation_expression=>anonymous_functionproperty_initializerrule, now uses adefault_valuefieldDue to the BCs I plan to bump version to
0.23.0after merging